-
Notifications
You must be signed in to change notification settings - Fork 364
Convert the output type of bool operation to int #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: inocsin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
Can you write test cases for this? |
I think we already have test cases for boolean operation |
Please check my pull #351 |
We now support aten::to operator which handles such masked multiplications. Closing this PR |
Description
There is a case
The output of aten::ge is Bool type, and there are three way to support the above graph
Type of change
Convert ouput type from bool to int
Checklist: