Skip to content

fix dynamo converter test case failure #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lanluo-nvidia
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia commented Jun 16, 2025

Description

example run:

https://github.com/pytorch/TensorRT/actions/runs/15669873129/job/44139691976?pr=3590
got
if converter_packet is None:

      raise UnsupportedOperatorException(
            f"Conversion of function {torch.typename(target)} not currently supported!"
        )

E torch_tensorrt.dynamo.conversion._TRTInterpreter.UnsupportedOperatorException: Conversion of function torch._ops.aten.aten::_assert_scalar not currently supported!

Fixes # (issue)
#3581

dynamo tracer with dynamic shape need to apply the post lowering passes to remove the _assert_scalar node

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: build system Issues re: Build system component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 16, 2025
@lanluo-nvidia lanluo-nvidia changed the base branch from main to lluo/fix_tensorrt_version_bug June 16, 2025 16:02
@github-actions github-actions bot requested a review from narendasan June 16, 2025 16:02
@github-actions github-actions bot removed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: build system Issues re: Build system labels Jun 16, 2025
@narendasan narendasan requested a review from peri044 June 16, 2025 16:26
@lanluo-nvidia lanluo-nvidia changed the base branch from lluo/fix_tensorrt_version_bug to main June 16, 2025 16:27
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants