Skip to content

remove torchvision dependency from build, optional for test #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025

Conversation

lanluo-nvidia
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia commented Jun 16, 2025

Description

remove torchvision as build dependency
only install during test

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

add torchvision to tests/py/requirements.txt
@lanluo-nvidia lanluo-nvidia self-assigned this Jun 16, 2025
@lanluo-nvidia lanluo-nvidia added the WIP Work is in progress, pull request should not be merged yet label Jun 16, 2025
@github-actions github-actions bot added component: tests Issues re: Tests component: api [Python] Issues re: Python API labels Jun 16, 2025
@github-actions github-actions bot requested a review from gs-olive June 16, 2025 21:46
@github-actions github-actions bot removed the component: api [Python] Issues re: Python API label Jun 16, 2025
@lanluo-nvidia lanluo-nvidia removed the WIP Work is in progress, pull request should not be merged yet label Jun 17, 2025
@lanluo-nvidia lanluo-nvidia changed the title remove torchvision from py/requirements.txt(WIP) remove torchvision from py/requirements.txt Jun 17, 2025
@lanluo-nvidia lanluo-nvidia changed the title remove torchvision from py/requirements.txt remove torchvision dependency from build, optional for test Jun 17, 2025
@lanluo-nvidia lanluo-nvidia requested review from narendasan and removed request for gs-olive June 17, 2025 14:25
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanluo-nvidia lanluo-nvidia merged commit 07e4643 into main Jun 17, 2025
75 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants