enable batch_size auto for model eval #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2675
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Aug 4, 2025
Summary: enables passing `--batch_size auto` to model eval script on LLaMa 3.1 8B and wikitext + hellaswag, this reduces the runtime from 13 minutes to 4.5 minutes on my machines (a 2.9x speedup) Test Plan: ``` with-proxy time python benchmarks/_models/eval_hf_models.py --model_id meta-llama/Llama-3.1-8B --tasks wikitext hellaswag --batch_size auto ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9a91dd6 ghstack-comment-id: 3151916665 Pull Request resolved: #2675
vkuzo
added
the
topic: not user facing
vkuzo
added a commit
that referenced
this pull request
Aug 4, 2025
Summary: enables passing `--batch_size auto` to model eval script on LLaMa 3.1 8B and wikitext + hellaswag, this reduces the runtime from 13 minutes to 4.5 minutes on my machines (a 2.9x speedup) Test Plan: ``` with-proxy time python benchmarks/_models/eval_hf_models.py --model_id meta-llama/Llama-3.1-8B --tasks wikitext hellaswag --batch_size auto ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 91c5dd0 ghstack-comment-id: 3151916665 Pull Request resolved: #2675
jerryzh168
approved these changes
Aug 4, 2025
vkuzo
added a commit
that referenced
this pull request
Aug 5, 2025
Summary: enables passing `--batch_size auto` to model eval script on LLaMa 3.1 8B and wikitext + hellaswag, this reduces the runtime from 13 minutes to 4.5 minutes on my machines (a 2.9x speedup) Test Plan: ``` with-proxy time python benchmarks/_models/eval_hf_models.py --model_id meta-llama/Llama-3.1-8B --tasks wikitext hellaswag --batch_size auto ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d4da3ce ghstack-comment-id: 3151916665 Pull Request resolved: #2675
yes, it does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
enables passing
--batch_size autoto model eval scripton LLaMa 3.1 8B and wikitext + hellaswag, this reduces the runtime from
13 minutes to 4.5 minutes on my machines (a 2.9x speedup)
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: