-
Notifications
You must be signed in to change notification settings - Fork 311
[moe training] add bench script for fp8 rowwise kernels and update autotune configs #2697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+357
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…totune configs stack-info: PR: #2697, branch: danielvegamyhre/stack/31
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2697
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
59e34b1
to
362cfb2
Compare
af159db
to
f6688be
Compare
This was referenced Aug 5, 2025
362cfb2
to
14acee2
Compare
14acee2
to
e3c97ec
Compare
e3c97ec
to
5118bcf
Compare
5118bcf
to
0305192
Compare
0305192
to
c621ce5
Compare
c621ce5
to
ab43973
Compare
ab43973
to
1fb9ee1
Compare
vkuzo
reviewed
Aug 6, 2025
print(tabulate(rows, headers=headers)) | ||
|
||
|
||
def benchmark_cuda_function_in_microseconds(f, *args): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have so many of these, maybe reuse in a separate PR?
vkuzo
approved these changes
Aug 6, 2025
6704fd3
to
c789281
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Aug 6, 2025
…totune configs stack-info: PR: #2697, branch: danielvegamyhre/stack/31
1fb9ee1
to
f124235
Compare
f124235
to
73b26f1
Compare
902d134
to
7e8b8c4
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Aug 6, 2025
…totune configs stack-info: PR: #2697, branch: danielvegamyhre/stack/31
73b26f1
to
d85d5db
Compare
d85d5db
to
9b4c4c6
Compare
3e059e3
to
4d57aa3
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Aug 7, 2025
…totune configs stack-info: PR: #2697, branch: danielvegamyhre/stack/31
dfc7d87
to
9e216ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[moe training] add bench script for fp8 rowwise kernels and update autotune configs
Performance vs torch.compile
It's faster for llama4 shape (16, 5120, 4*5120), but slower for skinny shapes.
There is more we can do, for example writing row major outputs was roughly 2x faster, but we need the outputs in col-major. I can probably look with NCU and figure out what's going on but for now this is a start.