Support optional_tensor_names in TorchAOBaseTensor
#2710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2710
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b6b0d9f with merge base c086ade ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jerryzh168
added a commit
that referenced
this pull request
Aug 7, 2025
Summary: Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated all common util functions to support `optional_tensor_names` list, including `__tensor_flatten__`, `__tensor_unflatten__`, ops like aten._to_copy, contiguous, alias etc. Test Plan: python test/test_utils.py Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2710, branch: jerryzh168/stack/17
jerryzh168
force-pushed
the
jerryzh168/stack/17
branch
from
650b1e5 to
a258628
Compare
This was referenced Aug 7, 2025
meta-cla
bot
added
the
CLA Signed
jerryzh168
force-pushed
the
jerryzh168/stack/16
branch
from
aee3dbb to
4a50bf7
Compare
jerryzh168
added a commit
that referenced
this pull request
Aug 7, 2025
Summary: Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated all common util functions to support `optional_tensor_names` list, including `__tensor_flatten__`, `__tensor_unflatten__`, ops like aten._to_copy, contiguous, alias etc. Test Plan: python test/test_utils.py Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2710, branch: jerryzh168/stack/17
jerryzh168
added
the
topic: not user facing
jerryzh168
force-pushed
the
jerryzh168/stack/17
branch
from
a258628 to
4a0d944
Compare
jerryzh168
added a commit
that referenced
this pull request
Aug 7, 2025
Summary: Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated all common util functions to support `optional_tensor_names` list, including `__tensor_flatten__`, `__tensor_unflatten__`, ops like aten._to_copy, contiguous, alias etc. Test Plan: python test/test_utils.py Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2710, branch: jerryzh168/stack/17
jerryzh168
force-pushed
the
jerryzh168/stack/17
branch
from
4a0d944 to
1f4d77f
Compare
jerryzh168
added a commit
that referenced
this pull request
Aug 7, 2025
Summary: Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated all common util functions to support `optional_tensor_names` list, including `__tensor_flatten__`, `__tensor_unflatten__`, ops like aten._to_copy, contiguous, alias etc. Test Plan: python test/test_utils.py Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2710, branch: jerryzh168/stack/17
jerryzh168
force-pushed
the
jerryzh168/stack/17
branch
from
1f4d77f to
bf8894c
Compare
jerryzh168
added a commit
that referenced
this pull request
Aug 7, 2025
Summary: Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated all common util functions to support `optional_tensor_names` list, including `__tensor_flatten__`, `__tensor_unflatten__`, ops like aten._to_copy, contiguous, alias etc. Test Plan: python test/test_utils.py Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2710, branch: jerryzh168/stack/17
jerryzh168
force-pushed
the
jerryzh168/stack/17
branch
from
bf8894c to
9045759
Compare
jerryzh168
force-pushed
the
jerryzh168/stack/17
branch
from
9045759 to
08670aa
Compare
jerryzh168
added a commit
that referenced
this pull request
Aug 7, 2025
Summary: Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated all common util functions to support `optional_tensor_names` list, including `__tensor_flatten__`, `__tensor_unflatten__`, ops like aten._to_copy, contiguous, alias etc. Test Plan: python test/test_utils.py Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2710, branch: jerryzh168/stack/17
jerryzh168
force-pushed
the
jerryzh168/stack/16
branch
from
e84a76d to
8983652
Compare
jerryzh168
added a commit
that referenced
this pull request
Aug 7, 2025
Summary: Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated all common util functions to support `optional_tensor_names` list, including `__tensor_flatten__`, `__tensor_unflatten__`, ops like aten._to_copy, contiguous, alias etc. Test Plan: python test/test_utils.py Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2710, branch: jerryzh168/stack/17
jerryzh168
force-pushed
the
jerryzh168/stack/17
branch
from
08670aa to
ad5988a
Compare
jerryzh168
force-pushed
the
jerryzh168/stack/16
branch
from
8983652 to
abcddcf
Compare
jerryzh168
added a commit
that referenced
this pull request
Aug 7, 2025
Summary: Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated all common util functions to support `optional_tensor_names` list, including `__tensor_flatten__`, `__tensor_unflatten__`, ops like aten._to_copy, contiguous, alias etc. Test Plan: python test/test_utils.py Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2710, branch: jerryzh168/stack/17
jerryzh168
force-pushed
the
jerryzh168/stack/17
branch
from
ad5988a to
a389ba8
Compare
drisspg
reviewed
Aug 8, 2025
There was a problem hiding this comment.
can you update the doc block for AoBaseTensor I think having class types so that users know what types it contains e.g. you can have optional_tensor_data_names: Optional[List[Tensor]]
so w/ a description of why you want to populate this field, what functions it can help you implement, etc...
jerryzh168
added a commit
that referenced
this pull request
Aug 8, 2025
Summary: Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated all common util functions to support `optional_tensor_names` list, including `__tensor_flatten__`, `__tensor_unflatten__`, ops like aten._to_copy, contiguous, alias etc. Test Plan: python test/test_utils.py Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2710, branch: jerryzh168/stack/17
jerryzh168
force-pushed
the
jerryzh168/stack/17
branch
from
a389ba8 to
bdd9ac6
Compare
sg, updated the doc, we can't add these fields by default since it's optional to define these fields |
Summary: Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated all common util functions to support `optional_tensor_names` list, including `__tensor_flatten__`, `__tensor_unflatten__`, ops like aten._to_copy, contiguous, alias etc. Test Plan: python test/test_utils.py Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2710, branch: jerryzh168/stack/17
jerryzh168
force-pushed
the
jerryzh168/stack/17
branch
from
bdd9ac6 to
b6b0d9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
optional_tensor_namesin TorchAOBaseTensor #2710Support
optional_tensor_namesin TorchAOBaseTensorSummary:
Allows subclasses inheriting from TorchAOBaseTensor to have optional tensor attributes, updated
all common util functions to support
optional_tensor_nameslist, including__tensor_flatten__,__tensor_unflatten__, ops like aten._to_copy, contiguous, alias etc.Test Plan:
python test/test_utils.py
Reviewers:
Subscribers:
Tasks:
Tags: