Change choose_qparams_per_token to choose_qparams_per_token_asymmetric #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is needed for xnnpack, we can support other patterns later Test Plan: CI, will be tested when xnnpack lowering is ready Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
jerryzh168
requested review from
kimishpatel,
cpuhrsch,
andrewor14 and
HDCharles
andrewor14
approved these changes
Mar 18, 2024
|
@jerryzh168 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jerryzh168 merged this pull request in 9c048eb. |
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
pytorch#61) Summary: Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ pytorch#61 This is needed for xnnpack, we can support other patterns later Pull Request resolved: pytorch#61 Test Plan: CI, will be tested when xnnpack lowering is ready Reviewed By: andrewor14 Differential Revision: D55031545 Pulled By: jerryzh168 fbshipit-source-id: 3908bf0e6e5638b611300b0a45cedabb3c0592b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
This is needed for xnnpack, we can support other patterns later
Test Plan:
CI, will be tested when xnnpack lowering is ready
Reviewers:
Subscribers:
Tasks:
Tags: