-
Notifications
You must be signed in to change notification settings - Fork 694
Enable CUDA filter graph #3159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
8 tasks
mthrok
added a commit
to mthrok/audio
that referenced
this issue
Mar 19, 2023
Summary: This commit adds CUDA frame support to FilterGraph It initializes and attaches CUDA frames context to FilterGraph, so that CUDA frames can be processed in FilterGraph. As a result, it enables 1. CUDA filter support such as `scale_cuda` 2. Properly retrieve the pixel format coming out of FilterGraph when CUDA HW acceleration is enabled. (currently it is reported as "cuda") Resolves pytorch#3159 Pull Request resolved: pytorch#3183 Differential Revision: D44183722 Pulled By: mthrok fbshipit-source-id: 263999172522233401109b9a0d13514883d95660
mthrok
added a commit
to mthrok/audio
that referenced
this issue
Mar 19, 2023
Summary: This commit adds CUDA frame support to FilterGraph It initializes and attaches CUDA frames context to FilterGraph, so that CUDA frames can be processed in FilterGraph. As a result, it enables 1. CUDA filter support such as `scale_cuda` 2. Properly retrieve the pixel format coming out of FilterGraph when CUDA HW acceleration is enabled. (currently it is reported as "cuda") Resolves pytorch#3159 Pull Request resolved: pytorch#3183 Differential Revision: D44183722 Pulled By: mthrok fbshipit-source-id: ae99c63c770234ec979008a31fcbe661d0265fb3
mthrok
added a commit
to mthrok/audio
that referenced
this issue
Mar 19, 2023
Summary: This commit adds CUDA frame support to FilterGraph It initializes and attaches CUDA frames context to FilterGraph, so that CUDA frames can be processed in FilterGraph. As a result, it enables 1. CUDA filter support such as `scale_cuda` 2. Properly retrieve the pixel format coming out of FilterGraph when CUDA HW acceleration is enabled. (currently it is reported as "cuda") Resolves pytorch#3159 Pull Request resolved: pytorch#3183 Differential Revision: D44183722 Pulled By: mthrok fbshipit-source-id: 7a1ec4717348965d178045c76b0bbe506140f8c7
mthrok
added a commit
to mthrok/audio
that referenced
this issue
Mar 20, 2023
Summary: This commit adds CUDA frame support to FilterGraph It initializes and attaches CUDA frames context to FilterGraph, so that CUDA frames can be processed in FilterGraph. As a result, it enables 1. CUDA filter support such as `scale_cuda` 2. Properly retrieve the pixel format coming out of FilterGraph when CUDA HW acceleration is enabled. (currently it is reported as "cuda") Resolves pytorch#3159 Pull Request resolved: pytorch#3183 Differential Revision: D44183722 Pulled By: mthrok fbshipit-source-id: 971f796c11a96d728065f84726bdb7acd6e656bc
mthrok
added a commit
to mthrok/audio
that referenced
this issue
Mar 20, 2023
Summary: This commit adds CUDA frame support to FilterGraph It initializes and attaches CUDA frames context to FilterGraph, so that CUDA frames can be processed in FilterGraph. As a result, it enables 1. CUDA filter support such as `scale_cuda` 2. Properly retrieve the pixel format coming out of FilterGraph when CUDA HW acceleration is enabled. (currently it is reported as "cuda") Resolves pytorch#3159 Pull Request resolved: pytorch#3183 Differential Revision: D44183722 Pulled By: mthrok fbshipit-source-id: d319fee3a6c03e1dbc985879f0eead879925b4c8
mthrok
added a commit
to mthrok/audio
that referenced
this issue
Mar 20, 2023
Summary: This commit adds CUDA frame support to FilterGraph It initializes and attaches CUDA frames context to FilterGraph, so that CUDA frames can be processed in FilterGraph. As a result, it enables 1. CUDA filter support such as `scale_cuda` 2. Properly retrieve the pixel format coming out of FilterGraph when CUDA HW acceleration is enabled. (currently it is reported as "cuda") Resolves pytorch#3159 Pull Request resolved: pytorch#3183 Differential Revision: D44183722 Pulled By: mthrok fbshipit-source-id: 7f3a223330cc5bc54f99c87c203494c948e9dfba
mthrok
added a commit
to mthrok/audio
that referenced
this issue
Mar 20, 2023
Summary: This commit adds CUDA frame support to FilterGraph It initializes and attaches CUDA frames context to FilterGraph, so that CUDA frames can be processed in FilterGraph. As a result, it enables 1. CUDA filter support such as `scale_cuda` 2. Properly retrieve the pixel format coming out of FilterGraph when CUDA HW acceleration is enabled. (currently it is reported as "cuda") Resolves pytorch#3159 Pull Request resolved: pytorch#3183 Differential Revision: D44183722 Pulled By: mthrok fbshipit-source-id: 394c16b2d95d6a741addd17b1284c901ba6a8de6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Currently, when performing GPU decoding/encoding, filter graph is disable.
We should enable filter graph so that it is more flexible for GPU processing.
implementation direction
scale_cuda
filter.Test code
Currently this causes segmentation fault at
audio/torchaudio/csrc/ffmpeg/filter_graph.cpp
Lines 168 to 174 in 9bb3507
The segfault happens in
cudascale_config_props
function ofvf_scale_cuda.c
, it seems thathw_device_context
is required.The text was updated successfully, but these errors were encountered: