Skip to content

Run GPU test for all PRs and fix setup #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2020
Merged

Run GPU test for all PRs and fix setup #1014

merged 2 commits into from
Nov 9, 2020

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Nov 6, 2020 •
edited
Loading

  • Enable GPU tests for all the PRs as we are seeing cases where CI jobs are failing due to bug or setup failure.
  • Fix GPU jobs where environment variable were not passed from configuration

@mthrok
Copy link
Contributor Author

mthrok commented Nov 6, 2020

wow why does python 3.9 get installed????

@mthrok
Copy link
Contributor Author

mthrok commented Nov 6, 2020 •
edited
Loading

Finding 1.
On Windows GPU VM, environment variables defined by parameters are not defined. This might be a bug on CCI side. environment was overwritten.

@mthrok
Copy link
Contributor Author

mthrok commented Nov 7, 2020

Finding 2.
Same for Linux GPU VM. parameters are not propagated.

vincentqb
vincentqb approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok changed the title Run GPU test for all PRs Run GPU test for all PRs and fix setup Nov 9, 2020
@mthrok mthrok marked this pull request as ready for review November 9, 2020 22:30
@mthrok mthrok merged commit 3b9e933 into pytorch:master Nov 9, 2020
@mthrok mthrok deleted the gpu-test branch November 9, 2020 22:30
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
@jgerityneurala @holly1238
Format imports according to PEP8 (pytorch#1014)
3e6d1f4 
Co-authored-by: holly1238 <[email protected]>
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
@fduwjj
[PT-D] Add TP and DDP into the example run script (pytorch#1014)
78acb79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

+1 more reviewer

@vincentqb vincentqb vincentqb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mthrok @cpuhrsch @vincentqb @facebook-github-bot