Skip to content

Fix doc commit script 2 #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix doc commit script 2 #1041

merged 1 commit into from
Nov 17, 2020

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Nov 17, 2020

The fix in #1034 got a little further in the document commit job, but there was another mistake: the documentation lives in the top-level directory not inside docs. This PR should fix it. Also fix for first-time creation of the directories if they do not exist.

vincentqb
vincentqb approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vincentqb vincentqb merged commit f3b9208 into pytorch:master Nov 17, 2020
@mattip
Copy link
Contributor Author

mattip commented Nov 18, 2020

The script almost runs to completion. It needs permission to push to the repo:

+ git push -u origin gh-pages
ERROR: The key you are authenticating with has been marked as read only.
fatal: Could not read from remote repository.

How does the pytorch/pytorch job get permission to write?

@mattip
Copy link
Contributor Author

mattip commented Nov 18, 2020 •
edited
Loading

Answering my own question: it is here. Someone with admin status needs to make a GITHUB_PYTORCHBOT_TOKEN for the repo ci, then this PR will need extending again.

@mthrok
Copy link
Collaborator

mthrok commented Nov 18, 2020

@seemethere @soumith Could you provide a guidance here regarding the push permission?

@mattip mattip mentioned this pull request Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattip @mthrok @vincentqb @facebook-github-bot