Add AudioEffector #3163
Add AudioEffector #3163
Conversation
#3192) Summary: OPUS encoder and VORBIS encoders require "strict=experimental" flags. This commit enables it automatically. The rational behind of it is typically we care if we can encode these formats at all and not how they are encoded. (This might be concern when these encoder becomes more mature on FFmpeg side and providing flags would result in weird behavior) Also when writing high-level functions that uses StreamWriter, if we do not set these flags, then these high-level functions have to add new options that should be passed down to StreamWriter, which turned out to be very painful in #3163 Pull Request resolved: #3192 Reviewed By: nateanl Differential Revision: D44275089 Pulled By: mthrok fbshipit-source-id: 74a757b4b7fc8467c8c88ffcb54fbaf89d6e4384
mthrok
force-pushed
the
effector
branch
3 times, most recently
from
bd0d52f to
1f8dbd1
Compare
|
You're using |
My implementations are aware of the potentially long audios, and they don't force the one-go operation. In this particular feature, I am providing two options. one-go or chunk-by-chunk process. It's up to users to pick which fashion they want to process their data. |
mthrok
force-pushed
the
effector
branch
11 times, most recently
from
6a43ad2 to
6e99aac
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| (applied,) = reader.pop_chunks() | ||
| return Tensor(applied) | ||
|
|
||
| def stream(self, waveform: Tensor, sample_rate: int, frames_per_chunk: int) -> Iterator[Tensor]: |
There was a problem hiding this comment.
does every effect require the specification of sample rate?
There was a problem hiding this comment.
Yes, without a user provided sample rate, we need to assume some default value, which is not universally applicable.
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D44576660 |
Summary: This commit adds a new feature AudioEffector, which can be used to apply various effects and codecs to waveforms in Tensor. Under the hood it uses StreamWriter and StreamReader to apply filters and encode/decode. This is going to replace the deprecated `apply_codec` and `apply_sox_effect_tensor` functions. It can also perform online, chunk-by-chunk filtering. Tutorial to follow. closes pytorch#3161 Pull Request resolved: pytorch#3163 Differential Revision: D44576660 Pulled By: mthrok fbshipit-source-id: 27e2a2af626188934a25e66d33c693ddf5bc580e
Summary: This commit adds a new feature AudioEffector, which can be used to apply various effects and codecs to waveforms in Tensor. Under the hood it uses StreamWriter and StreamReader to apply filters and encode/decode. This is going to replace the deprecated `apply_codec` and `apply_sox_effect_tensor` functions. It can also perform online, chunk-by-chunk filtering. Tutorial to follow. closes pytorch#3161 Pull Request resolved: pytorch#3163 Differential Revision: D44576660 Pulled By: mthrok fbshipit-source-id: 42097e758598c098313ff5a6b9563183604d6842
|
This pull request was exported from Phabricator. Differential Revision: D44576660 |
Summary: This commit adds a new feature AudioEffector, which can be used to apply various effects and codecs to waveforms in Tensor. Under the hood it uses StreamWriter and StreamReader to apply filters and encode/decode. This is going to replace the deprecated `apply_codec` and `apply_sox_effect_tensor` functions. It can also perform online, chunk-by-chunk filtering. Tutorial to follow. closes pytorch#3161 Pull Request resolved: pytorch#3163 Differential Revision: D44576660 Pulled By: mthrok fbshipit-source-id: 1ac9613b3e5e5fa51dcc19e54978f23d82f5fa96
|
This pull request was exported from Phabricator. Differential Revision: D44576660 |
Summary: This commit adds a new feature AudioEffector, which can be used to apply various effects and codecs to waveforms in Tensor. Under the hood it uses StreamWriter and StreamReader to apply filters and encode/decode. This is going to replace the deprecated `apply_codec` and `apply_sox_effect_tensor` functions. It can also perform online, chunk-by-chunk filtering. Tutorial to follow. closes pytorch#3161 Pull Request resolved: pytorch#3163 Differential Revision: D44576660 Pulled By: mthrok fbshipit-source-id: e6794d1d434c95db5cd24b3bd11f5e5e2a9671da
|
This pull request was exported from Phabricator. Differential Revision: D44576660 |
|
Hey @mthrok. |
This commit adds a new feature AudioEffector, which can be used to
apply various effects and codecs to waveforms in Tensor.
Under the hood it uses StreamWriter and StreamReader to apply
filters and encode/decode.
This is going to replace the deprecated
apply_codecandapply_sox_effect_tensorfunctions.It can also perform online, chunk-by-chunk filtering.
Tutorial to follow.
closes #3161