Add EncodingConfig #3164
Closed
Add EncodingConfig #3164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D43861413 |
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@hwangjeff has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D43861413 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 16, 2023
Summary: Pull Request resolved: pytorch#3164 Differential Revision: D43861413 Pulled By: hwangjeff fbshipit-source-id: 13045367e3894d9a19710ffb0862f996ebc006f2
mthrok
force-pushed
the
export-D43861413
branch
from
bef1ef9 to
5a957a6
Compare
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 16, 2023
Summary: Pull Request resolved: pytorch#3164 Differential Revision: D43861413 Pulled By: hwangjeff fbshipit-source-id: 2b6f63c7205ffd9690384a51b36d3f56aa05c2aa
mthrok
force-pushed
the
export-D43861413
branch
from
5a957a6 to
a35f749
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43861413 |
Summary: Pull Request resolved: pytorch#3164 Differential Revision: D43861413 Pulled By: hwangjeff fbshipit-source-id: 6278ab2fdf2faf7c6593665cd4141b206cde459a
|
This pull request was exported from Phabricator. Differential Revision: D43861413 |
mthrok
force-pushed
the
export-D43861413
branch
from
a35f749 to
d424132
Compare
Closed
hwangjeff
pushed a commit
to hwangjeff/audio
that referenced
this pull request
Mar 16, 2023
Summary: Pull Request resolved: pytorch#3164 Differential Revision: D43861413 Pulled By: hwangjeff fbshipit-source-id: d26ffa86f369dfc6ff30caaf77ab080460436f05
hwangjeff
pushed a commit
to hwangjeff/audio
that referenced
this pull request
Mar 17, 2023
Summary: Adds config object `EncodingConfig` and modifies `StreamWriter` to allow for passing in additional encoder configuration parameters, e.g. bit rate and compression level. Pull Request resolved: pytorch#3179 Pull Request resolved: pytorch#3164 Reviewed By: mthrok Differential Revision: D43861413 Pulled By: hwangjeff fbshipit-source-id: 65b519c82fa9d9373f718ad895fcb42d4f76a262
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
Summary: Adds config object `EncodingConfig` and modifies `StreamWriter` to allow for passing in additional encoder configuration parameters, e.g. bit rate and compression level. Pull Request resolved: #3179 Pull Request resolved: #3164 Reviewed By: mthrok Differential Revision: D43861413 Pulled By: hwangjeff fbshipit-source-id: c1682cb2f6e682ab6f1a506511d2be7c7b254161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D43861413