[Cherry-picked 2.0.1] Fix path-like object support in FFmpeg dispatcher #3243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
changed the title
In dispatcher mode, FFmpeg backend does not handle path-like object, and C++ implementation raises an error. This commit fixes it by normalizing path-like object to string.
mthrok
force-pushed
the
fix-ffmpeg-dispatcher
branch
from
d4fee19 to
81e78ba
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nateanl
approved these changes
Apr 5, 2023
|
Hey @mthrok. |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 6, 2023
Summary: In dispatcher mode, FFmpeg backend does not handle file-like object, and C++ implementation raises an issue. This commit fixes it by normalizing file-like object to string. Pull Request resolved: pytorch#3243 Reviewed By: nateanl Differential Revision: D44719280 Pulled By: mthrok fbshipit-source-id: 9dae459e2a5fb4992b4ef53fe4829fe8c35b2edd
mthrok
changed the title
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 6, 2023
Follow up of pytorch#3243. Save compat module had different semantics than info and load, which requires different way of performing path normalization.
mthrok
changed the title
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 6, 2023
Follow up of pytorch#3243. Save compat module had different semantics than info and load, which requires different way of performing path normalization.
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
Summary: Follow up of #3243. Save compat module had different semantics than info and load, which requires different way of performing path normalization. Pull Request resolved: #3248 Reviewed By: hwangjeff Differential Revision: D44774997 Pulled By: mthrok fbshipit-source-id: 4b967ae3ca6b45850d455b8e95aaa31762c5457e
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 7, 2023
…#3248) Summary: Follow up of pytorch#3243. Save compat module had different semantics than info and load, which requires different way of performing path normalization. Pull Request resolved: pytorch#3248 Reviewed By: hwangjeff Differential Revision: D44774997 Pulled By: mthrok fbshipit-source-id: 4b967ae3ca6b45850d455b8e95aaa31762c5457e
mthrok
added a commit
that referenced
this pull request
Apr 7, 2023
#3248) (#3245) * Fix path-like object support in FFmpeg dispatcher (#3243) Summary: In dispatcher mode, FFmpeg backend does not handle file-like object, and C++ implementation raises an issue. This commit fixes it by normalizing file-like object to string. Pull Request resolved: #3243 Reviewed By: nateanl Differential Revision: D44719280 Pulled By: mthrok fbshipit-source-id: 9dae459e2a5fb4992b4ef53fe4829fe8c35b2edd * Fix path normalization for StreamWriter-based save operation (#3248) Summary: Follow up of #3243. Save compat module had different semantics than info and load, which requires different way of performing path normalization. Pull Request resolved: #3248 Reviewed By: hwangjeff Differential Revision: D44774997 Pulled By: mthrok fbshipit-source-id: 4b967ae3ca6b45850d455b8e95aaa31762c5457e
mthrok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dispatcher mode, FFmpeg backend does not handle path-like object,
and C++ implementation raises an error.
This commit fixes it by normalizing path-like object to string.