Remove custom flashlight import #3246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
cleanup-flashlight
branch
from
d912519 to
826c6a6
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: In pytorch#3232, the CTC decoder is excluded from binary distribution. To use CTCDecoder, users need to install flashlight-text. Currently, if flashlight-text is not available, torchaudio still attempts to import the custom bundle. This commit clean up this behavior by delaying the error until one of the components is actually used, and providing a better message. Pull Request resolved: pytorch#3246 Test Plan: Binary smoke tests import torchaudio without installing flashlight. Unit test CI jobs run the CTC decoder with flashlight installed. Differential Revision: D44748413 Pulled By: mthrok fbshipit-source-id: 3314831e0dbd8ff40f249e81b81c311c91d4d198
|
This pull request was exported from Phabricator. Differential Revision: D44748413 |
mthrok
force-pushed
the
cleanup-flashlight
branch
from
826c6a6 to
ce55956
Compare
|
Hey @mthrok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3232, the CTC decoder is excluded from binary distribution.
To use CTCDecoder, users need to install flashlight-text.
Currently, if flashlight-text is not available, torchaudio still attempts to import the custom bundle.
This commit clean up this behavior by delaying the error until one of the components is actually used,
and providing a better message.
Test:
Binary smoke tests import torchaudio without installing flashlight.
Unit test CI jobs run the CTC decoder with flashlight installed.