Skip to content

1. add -t for multiple test rounds 2. separate time for each test phase #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

buttercannfly
Copy link

Add multi-round testing capability and granular timing metrics

This PR introduces two improvements to test.py:

  1. Add -t option to support multiple test rounds

    • Enables running the model through several consecutive test iterations
    • Provides more comprehensive performance evaluation
    • Available as an advanced option for users needing deeper analysis
  2. Separate timing measurements for each test phase

    • Breaks down execution time by testing stage
    • Improves visibility into performance bottlenecks
    • Helps identify specific areas for optimization

These changes enhance both testing capabilities and observability without affecting the default user experience.

2. record time for model init, run and clean
@facebook-github-bot
Copy link
Contributor

Hi @buttercannfly!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants