Skip to content

Properly handle observation_noise kwarg for BatchedMultiOutputGPyTorchModel #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Balandat
Copy link
Contributor

Fixes a bug where the observation_noise kwarg was disregarded for models of the class BatchedMultiOutputGPyTorchModel.

…hModel

Fixes a bug where the `observation_noise` kwarg was disregarded for models of the class `BatchedMultiOutputGPyTorchModel`.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 24, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Balandat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov-io
Copy link

codecov-io commented Jun 24, 2019

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #182    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          57     54     -3     
  Lines        1882   1778   -104     
======================================
- Hits         1882   1778   -104
Impacted Files Coverage Δ
botorch/models/gpytorch.py 100% <100%> (ø) ⬆️
...rch/models/fidelity_kernels/downsampling_kernel.py
...odels/fidelity_kernels/exponential_decay_kernel.py
botorch/models/fidelity_kernels/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c64fe...c8fa9cc. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@Balandat merged this pull request in 5c33d69.

@Balandat Balandat deleted the fix_observation_noise branch June 27, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants