Yarn: Regenerate lockfile to unblock dependabot #2837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot failed to update a dependency (https://github.com/pytorch/botorch/actions/runs/14734256627/job/41356188770) to a non-vulnerable version because of transitive dependencies. The upstream package was updated to use a non-vulnerable version but that isn't reflected in our existing lockfile. Deleting and regenerating resolves this. Relevant discussion in Docusaurus issue thread: facebook/docusaurus#10491 (comment) Test Plan: Before: ``` (venv) ~/Projects/botorch/website (main ✔) yarn audit yarn audit v1.22.22 warning package.json: No license field warning ../../../package.json: No license field warning No license field ┌───────────────┬──────────────────────────────────────────────────────────────┐ │ high │ Unpatched `path-to-regexp` ReDoS in 0.1.x │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Package │ path-to-regexp │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Patched in │ >=0.1.12 │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Dependency of │ @docusaurus/core │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Path │ @docusaurus/core > webpack-dev-server > express > │ │ │ path-to-regexp │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ More info │ https://www.npmjs.com/advisories/1101844 │ └───────────────┴──────────────────────────────────────────────────────────────┘ ┌───────────────┬──────────────────────────────────────────────────────────────┐ │ high │ Unpatched `path-to-regexp` ReDoS in 0.1.x │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Package │ path-to-regexp │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Patched in │ >=0.1.12 │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Dependency of │ @docusaurus/preset-classic │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Path │ @docusaurus/preset-classic > @docusaurus/core > │ │ │ webpack-dev-server > express > path-to-regexp │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ More info │ https://www.npmjs.com/advisories/1101844 │ └───────────────┴──────────────────────────────────────────────────────────────┘ ┌───────────────┬──────────────────────────────────────────────────────────────┐ │ high │ Unpatched `path-to-regexp` ReDoS in 0.1.x │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Package │ path-to-regexp │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Patched in │ >=0.1.12 │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Dependency of │ @docusaurus/preset-classic │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Path │ @docusaurus/preset-classic > @docusaurus/plugin-content-blog │ │ │ > @docusaurus/core > webpack-dev-server > express > │ │ │ path-to-regexp │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ More info │ https://www.npmjs.com/advisories/1101844 │ └───────────────┴──────────────────────────────────────────────────────────────┘ ┌───────────────┬──────────────────────────────────────────────────────────────┐ │ high │ Unpatched `path-to-regexp` ReDoS in 0.1.x │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Package │ path-to-regexp │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Patched in │ >=0.1.12 │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Dependency of │ @docusaurus/preset-classic │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Path │ @docusaurus/preset-classic > @docusaurus/theme-classic > │ │ │ @docusaurus/plugin-content-blog > @docusaurus/core > │ │ │ webpack-dev-server > express > path-to-regexp │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ More info │ https://www.npmjs.com/advisories/1101844 │ └───────────────┴──────────────────────────────────────────────────────────────┘ 4 vulnerabilities found - Packages audited: 1477 Severity: 4 High ✨ Done in 1.42s. ``` After: ``` (venv) ~/Projects/botorch/website (main ✔) rm yarn.lock (venv) ~/Projects/botorch/website (main ✗) yarn && yarn audit yarn install v1.22.22 warning package.json: No license field warning ../../../package.json: No license field info No lockfile found. warning No license field [1/4] 🔍 Resolving packages... warning @docusaurus/core > del > [email protected]: Rimraf versions prior to v4 are no longer supported warning @docusaurus/core > webpack-dev-server > [email protected]: Rimraf versions prior to v4 are no longer supported warning @docusaurus/core > shelljs > [email protected]: Glob versions prior to v9 are no longer supported warning @docusaurus/core > del > rimraf > [email protected]: Glob versions prior to v9 are no longer supported warning @docusaurus/core > react-dev-utils > fork-ts-checker-webpack-plugin > [email protected]: Glob versions prior to v9 are no longer supported warning @docusaurus/core > shelljs > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful. warning @docusaurus/core > react-dev-utils > fork-ts-checker-webpack-plugin > [email protected]: this will be v4 warning @docusaurus/core > webpack-dev-server > webpack-dev-middleware > [email protected]: this will be v4 warning plotly.js > color-rgba > color-space > [email protected]: Redundant dependency in your project. [2/4] 🚚 Fetching packages... warning Pattern ["react-helmet-async@npm:@slorber/react-helmet-async@*"] is trying to unpack in the same destination "/Users/cristianlara/Library/Caches/Yarn/v6/npm-react-helmet-async-1.3.0-11fbc6094605cf60aa04a28c17e0aab894b4ecff-integrity/node_modules/react-helmet-async" as pattern ["react-helmet-async@npm:@slorber/[email protected]","react-helmet-async@^1.3.0"]. This could result in non-deterministic behavior, skipping. [3/4] 🔗 Linking dependencies... warning " > @docusaurus/[email protected]" has unmet peer dependency "@mdx-js/react@^3.0.0". warning "@docusaurus/core > [email protected]" has unmet peer dependency "react-loadable@*". warning "@docusaurus/core > react-dev-utils > [email protected]" has unmet peer dependency "typescript@>= 2.7". warning "@docusaurus/core > @docusaurus/mdx-loader > @mdx-js/mdx > recma-jsx > [email protected]" has unmet peer dependency "acorn@^6.0.0 || ^7.0.0 || ^8.0.0". warning "@docusaurus/preset-classic > @docusaurus/theme-classic > @mdx-js/[email protected]" has unmet peer dependency "@types/react@>=16". warning "@docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6". warning "@docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6". warning "@docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "search-insights@>= 1 < 3". warning "plotly.js > [email protected]" has unmet peer dependency "webpack@^5.27.0". warning "plotly.js > @plotly/mapbox-gl > @mapbox/[email protected]" has unmet peer dependency "mapbox-gl@>=0.32.1 <2.0.0". [4/4] 🔨 Building fresh packages... success Saved lockfile. ✨ Done in 34.94s. yarn audit v1.22.22 warning package.json: No license field warning ../../../package.json: No license field warning No license field 0 vulnerabilities found - Packages audited: 1482 ✨ Done in 0.70s. ```
facebook-github-bot
added
the
CLA Signed
CristianLara
changed the title
CristianLara
changed the title
|
@CristianLara has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
saitcakmak
approved these changes
Apr 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 211 211
Lines 19320 19320
=========================================
Hits 19320 19320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@CristianLara merged this pull request in ed2e5c0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot failed to update a dependency (https://github.com/pytorch/botorch/actions/runs/14734256627/job/41356188770) to a non-vulnerable version because of transitive dependencies. The upstream package was updated to use a non-vulnerable version but that isn't reflected in our existing lockfile. Deleting and regenerating resolves this.
Relevant discussion in Docusaurus issue thread: facebook/docusaurus#10491 (comment)
Test Plan:
Before:
After: