Skip to content

Commit eb98223

Browse files
peterjc123soumith
authored andcommitted
# This is a combination of 3 commits.
# This is the 1st commit message: # This is a combination of 16 commits. # This is the 1st commit message: . # This is the commit message #2: Enable wheel tests # This is the commit message #3: Remove useless % # This is the commit message #4: Debug CPU conda # This is the commit message #5: . # This is the commit message #6: . # This is the commit message #7: Revert debugging stuff # This is the commit message #8: . # This is the commit message #9: Revert to normal # This is the commit message #10: Revert to legacy version # This is the commit message #11: Disable all except CPU conda # This is the commit message #12: Explicit python version # This is the commit message #13: Revert "Explicit python version" This reverts commit a45b285. # This is the commit message #14: Revert "Disable all except CPU conda" This reverts commit 2c69de7. # This is the commit message #15: Use branches first # This is the commit message #16: Use hash # This is the commit message #2: . # This is the commit message #3: .
1 parent 50d345a commit eb98223

File tree

8 files changed

+68
-41
lines changed

8 files changed

+68
-41
lines changed

run_tests.sh

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,26 @@ popd
137137
# real problems. Once these are on circleci and a smoke-binary-build is added
138138
# to PRs then this should stop happening and these can be re-enabled.
139139
echo "Not running unit tests. Hopefully these problems are caught by CI"
140-
exit 0
140+
# exit 0
141141

142142

143143
##############################################################################
144144
# Running unit tests (except not right now)
145145
##############################################################################
146146
echo "$(date) :: Starting tests for $package_type package for python$py_ver and $cuda_ver"
147147

148+
if [[ "$OSTYPE" == "msys" ]]; then
149+
echo
150+
echo "$(date) :: Calling 'python test/run_test.py -v'"
151+
152+
python test/run_test.py -v
153+
154+
echo
155+
echo "$(date) :: Finished 'python test/run_test.py -v'"
156+
157+
exit 0
158+
fi
159+
148160
# We keep track of exact tests to skip, as otherwise we would be hardly running
149161
# any tests. But b/c of issues working with pytest/normal-python-test/ and b/c
150162
# of special snowflake tests in test/run_test.py we also take special care of

windows/azure-pipelines.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ jobs:
1818
spec: 'CPU'
1919
msagent: false
2020

21-
- template: templates/build_task.yml
22-
parameters:
23-
package: 'Wheels'
24-
spec: 'CUDA'
25-
msagent: false
21+
# - template: templates/build_task.yml
22+
# parameters:
23+
# package: 'Wheels'
24+
# spec: 'CUDA'
25+
# msagent: false
2626

2727
- template: templates/build_task.yml
2828
parameters:

windows/internal/clone.bat

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ set PYTORCH_BRANCH=%last_commit%
4343
IF "%PYTORCH_BRANCH%" == "" (
4444
set PYTORCH_BRANCH=v%PYTORCH_BUILD_VERSION%
4545
)
46-
git checkout tags/%PYTORCH_BRANCH%
47-
IF ERRORLEVEL 1 git checkout %PYTORCH_BRANCH%
46+
git checkout %PYTORCH_BRANCH%
47+
IF ERRORLEVEL 1 git checkout tags/%PYTORCH_BRANCH%
4848

4949
:submodule
5050

windows/internal/publish.bat

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ if NOT "%CUDA_VERSION%" == "cpu" (
99
set PACKAGE_SUFFIX=
1010
)
1111

12+
if "%PACKAGEFULLNAME%" == "Conda" (
13+
set PACKAGE=conda
14+
) else (
15+
set PACKAGE=wheels
16+
)
17+
1218
set PUBLISH_BRANCH=%PACKAGE%_%DESIRED_PYTHON%%PACKAGE_SUFFIX%
1319

1420
git clone %ARTIFACT_REPO_URL% -b %PUBLISH_BRANCH% --single-branch >nul 2>&1
@@ -52,7 +58,7 @@ if "%RETRY_TIMES%" == "" (
5258
set /a SLEEP_TIME=%SLEEP_TIME%*2
5359
)
5460

55-
git push origin %PUBLISH_BRANCH%% -f > nul 2>&1
61+
git push origin %PUBLISH_BRANCH% -f > nul 2>&1
5662

5763
IF ERRORLEVEL 1 (
5864
echo Git push retry times remaining: %RETRY_TIMES%

windows/internal/setup.bat

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,9 @@ if "%BUILD_PYTHONLESS%" == "" goto pytorch else goto libtorch
3535
set VARIANT=shared-with-deps
3636

3737
mkdir libtorch
38-
mkdir libtorch\bin
39-
mkdir libtorch\cmake
40-
mkdir libtorch\include
38+
set "INSTALL_DIR=%CD%\libtorch"
4139
mkdir libtorch\lib
42-
mkdir libtorch\share
43-
mkdir libtorch\test
40+
copy /Y torch\lib\*.dll libtorch\lib\
4441

4542
mkdir build
4643
pushd build

windows/internal/test.bat

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ if ERRORLEVEL 1 exit /b 1
1818
python -c "from caffe2.python import core"
1919
if ERRORLEVEL 1 exit /b 1
2020

21-
echo "Checking that MKL is available"
21+
echo Checking that MKL is available
2222
python -c "import torch; exit(0 if torch.backends.mkl.is_available() else 1)"
2323
if ERRORLEVEL 1 exit /b 1
2424

@@ -35,26 +35,25 @@ for /F "delims=" %%i in ('wmic path win32_VideoController get name') do (
3535
endlocal & set NVIDIA_GPU_EXISTS=%NVIDIA_GPU_EXISTS%
3636

3737
if NOT "%CUDA_PREFIX%" == "cpu" if "%NVIDIA_GPU_EXISTS%" == "1" (
38-
python -c "import torch; torch.rand(1).cuda(); exit(0 if torch.cuda.has_magma else 1)"
39-
if ERRORLEVEL 1 exit /b 1
40-
4138
echo Checking that CUDA archs are setup correctly
4239
python -c "import torch; torch.randn([3,5]).cuda()"
4340
if ERRORLEVEL 1 exit /b 1
4441

4542
echo Checking that magma is available
4643
python -c "import torch; torch.rand(1).cuda(); exit(0 if torch.cuda.has_magma else 1)"
4744
if ERRORLEVEL 1 exit /b 1
45+
4846
echo Checking that CuDNN is available
4947
python -c "import torch; exit(0 if torch.backends.cudnn.is_available() else 1)"
5048
if ERRORLEVEL 1 exit /b 1
5149
)
5250

53-
echo Not running unit tests. Hopefully these problems are caught by CI
54-
goto test_end
51+
REM echo Not running unit tests. Hopefully these problems are caught by CI
52+
REM goto test_end
5553

5654
cd pytorch\test
57-
python run_test.py -v -pt -x c10d distributed thd_distributed
55+
REM python run_test.py -v -pt -x c10d distributed thd_distributed
56+
python run_test.py -v
5857

5958
if ERRORLEVEL 1 exit /b 1
6059

windows/templates/build_task.yml

Lines changed: 25 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ parameters:
88
cudaEnabled: true
99
condaEnabled: true
1010
wheelsEnabled: true
11-
override: false
11+
override: true
1212

1313
jobs:
1414
- job: 'Windows_${{ parameters.spec }}_${{ parameters.package }}_Build'
@@ -26,13 +26,15 @@ jobs:
2626
variables:
2727
- ${{ if eq(parameters.override, 'true') }}:
2828
- name: PYTORCH_BUILD_VERSION
29-
value: '1.0.0'
29+
value: '1.0.1'
3030
- name: PYTORCH_BUILD_NUMBER
3131
value: 1
3232
- name: PYTORCH_REPO
3333
value: 'pytorch'
3434
- name: PYTORCH_BRANCH
35-
value: 'v1.0.0'
35+
value: '743fdbdb192dd0f07d51d6f94f8b47984484b54f'
36+
- name: TORCH_CONDA_BUILD_FOLDER
37+
value: 'pytorch-1.0.1'
3638
- ${{ if eq(parameters.msagent, 'true') }}:
3739
- name: USE_SCCACHE
3840
value: 0
@@ -110,7 +112,7 @@ jobs:
110112
${{ if eq(parameters.msagent, 'true') }}:
111113
vmImage: 'win1803'
112114
${{ if eq(parameters.msagent, 'false') }}:
113-
name: 'pytorch'
115+
name: 'release'
114116

115117
steps:
116118
- checkout: self
@@ -120,7 +122,7 @@ jobs:
120122
parameters:
121123
msagent: ${{ parameters.msagent }}
122124

123-
- template: setup_nightly_variables.yml
125+
# - template: setup_nightly_variables.yml
124126

125127
- ${{ if eq(parameters.package, 'Wheels') }}:
126128
- template: build_wheels.yml
@@ -136,21 +138,24 @@ jobs:
136138
- template: publish_test_results.yml
137139
parameters:
138140
msagent: ${{ parameters.msagent }}
139-
140-
- ${{ if and(eq(parameters.package, 'Wheels'), eq(parameters.spec, 'CPU')) }}:
141-
- template: upload_to_s3.yml
141+
- template: publish_packages.yml
142142
parameters:
143-
cuVer: '$(CUDA_VERSION)'
144-
cudaVer: '$(CUDA_VERSION)'
143+
package: ${{ parameters.package }}
145144

146-
- ${{ if and(eq(parameters.package, 'Wheels'), ne(parameters.spec, 'CPU')) }}:
147-
- template: upload_to_s3.yml
148-
parameters:
149-
cuVer: 'cu$(CUDA_VERSION)'
150-
cudaVer: 'cuda$(CUDA_VERSION)'
145+
# - ${{ if and(eq(parameters.package, 'Wheels'), eq(parameters.spec, 'CPU')) }}:
146+
# - template: upload_to_s3.yml
147+
# parameters:
148+
# cuVer: '$(CUDA_VERSION)'
149+
# cudaVer: '$(CUDA_VERSION)'
151150

152-
- ${{ if eq(parameters.package, 'Conda') }}:
153-
- template: upload_to_conda.yml
154-
parameters:
155-
user: $(peterjc_conda_username)
156-
pass: $(peterjc_conda_password)
151+
# - ${{ if and(eq(parameters.package, 'Wheels'), ne(parameters.spec, 'CPU')) }}:
152+
# - template: upload_to_s3.yml
153+
# parameters:
154+
# cuVer: 'cu$(CUDA_VERSION)'
155+
# cudaVer: 'cuda$(CUDA_VERSION)'
156+
157+
# - ${{ if eq(parameters.package, 'Conda') }}:
158+
# - template: upload_to_conda.yml
159+
# parameters:
160+
# user: $(peterjc_conda_username)
161+
# pass: $(peterjc_conda_password)
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
parameters:
2+
package: ''
3+
4+
steps:
5+
- script: 'windows/internal/publish.bat'
6+
displayName: 'Upload packages to Azure DevOps Repo'
7+
env:
8+
PACKAGEFULLNAME: ${{ parameters.package }}

0 commit comments

Comments
 (0)