Skip to content

make nnpack conda build with cmake #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2017

Conversation

killeent
Copy link
Contributor

@Maratyszcza added CMAKE build for NNPACK which is a better approach for building than the old way for Conda, so we switch to using it here.

@killeent
Copy link
Contributor Author

cc @apaszke + @soumith for your opinions - the only real difference between this and the old one is that it installs all of the headers and libraries associated with the NNPACK build into Conda, where as I would imagine we only want the NNPACK ones. Should I go ahead and set this up?

@soumith soumith merged commit 1560620 into pytorch:master Oct 23, 2017
peterjc123 referenced this pull request in peterjc123/builder Apr 28, 2019
# This is the 1st commit message:

# This is a combination of 16 commits.
# This is the 1st commit message:

.

# This is the commit message #2:

Enable wheel tests

# This is the commit message #3:

Remove useless %

# This is the commit message #4:

Debug CPU conda

# This is the commit message #5:

.

# This is the commit message #6:

.

# This is the commit message #7:

Revert debugging stuff

# This is the commit message #8:

.

# This is the commit message #9:

Revert to normal

# This is the commit message #10:

Revert to legacy version

# This is the commit message #11:

Disable all except CPU conda

# This is the commit message #12:

Explicit python version

# This is the commit message #13:

Revert "Explicit python version"

This reverts commit a45b285.

# This is the commit message #14:

Revert "Disable all except CPU conda"

This reverts commit 2c69de7.

# This is the commit message #15:

Use branches first

# This is the commit message #16:

Use hash

# This is the commit message #2:

.

# This is the commit message #3:

.
soumith pushed a commit that referenced this pull request Apr 28, 2019
# This is the 1st commit message:

# This is a combination of 16 commits.
# This is the 1st commit message:

.

# This is the commit message #2:

Enable wheel tests

# This is the commit message #3:

Remove useless %

# This is the commit message #4:

Debug CPU conda

# This is the commit message #5:

.

# This is the commit message #6:

.

# This is the commit message #7:

Revert debugging stuff

# This is the commit message #8:

.

# This is the commit message #9:

Revert to normal

# This is the commit message #10:

Revert to legacy version

# This is the commit message #11:

Disable all except CPU conda

# This is the commit message #12:

Explicit python version

# This is the commit message #13:

Revert "Explicit python version"

This reverts commit a45b285.

# This is the commit message #14:

Revert "Disable all except CPU conda"

This reverts commit 2c69de7.

# This is the commit message #15:

Use branches first

# This is the commit message #16:

Use hash

# This is the commit message #2:

.

# This is the commit message #3:

.
jataylo pushed a commit to jataylo/builder that referenced this pull request Jan 9, 2023
* Remove miopen custom build step

* Bundle MIOpen db files in wheel

* Correct path
jataylo added a commit to jataylo/builder that referenced this pull request Jan 9, 2023
jataylo added a commit to jataylo/builder that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants