Skip to content

Get rid of libuv requirements on Unix #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2022
Merged

Get rid of libuv requirements on Unix #1012

merged 1 commit into from
May 20, 2022

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Apr 1, 2022

As libuv is bundled with tensorpipe and after pytorch/pytorch#77312 can be used by Gloo backend as well

Tested in pytorch/pytorch#74141

As `libuv` recipe contains `run_export`, which adds it as a runtime requirement, despite the fact that PyTorch is linked statically with it
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malfet malfet changed the title Move libuv to build requirements on Unix Get rid of libuv requirements on Unix May 20, 2022
@malfet malfet merged commit 19dccd7 into main May 20, 2022
@malfet malfet deleted the malfet-patch-2 branch May 20, 2022 23:13
malfet added a commit that referenced this pull request Jun 13, 2022
As `libuv` recipe contains `run_export`, which adds it as a runtime requirement, despite the fact that PyTorch is linked statically with it

(cherry picked from commit 19dccd7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants