This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Adds infra to use NCCL from pypi #1184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atalman
reviewed
Nov 8, 2022
atalman
suggested changes
Nov 8, 2022
|
Reopened here #1196 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs nccl from NVIDIA developer website, links PyTorch against this system NCCL, and points rpath to the pypi nccl wheel.
Testing plan: use this PR to build pytorch and generate a wheel. Test that wheel with some distributed workload that uses NCCL.