Skip to content

Adding limit windows builds logic #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Adding limit windows builds logic #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9affe36
Adding limit windows builds logic
atalman Feb 8, 2023
6acd78a
Remove empty space
atalman Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/scripts/validate_binaries.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ else
INSTALLATION_PYPI=${INSTALLATION_PYPI/"index-url"/"extra-index-url"}
conda run -p ${ENV_NAME}_pypi ${INSTALLATION_PYPI}
conda run -p ${ENV_NAME}_pypi python ./test/smoke_test/smoke_test.py --package torchonly
conda activate base
conda deactivate
conda env remove -p ${ENV_NAME}_pypi
fi

Expand All @@ -41,5 +41,7 @@ else
fi

python ./test/smoke_test/smoke_test.py
conda deactivate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be aligned with the else, i.e. directly above the fi?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nvm. It was only created inside this else statement. So it should be correct.

conda env remove -n ${ENV_NAME}
fi
fi
10 changes: 10 additions & 0 deletions .github/workflows/validate-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ on:
default: ""
required: false
type: string
limit-win-builds:
description: "Limit windows builds to single python/cuda config"
default: "disable"
type: string
workflow_dispatch:
inputs:
os:
Expand Down Expand Up @@ -49,6 +53,11 @@ on:
default: ""
required: false
type: string
limit-win-builds:
description: "Limit windows builds to single python/cuda config"
default: "disable"
required: false
type: string

jobs:
win:
Expand All @@ -57,6 +66,7 @@ jobs:
with:
channel: ${{ inputs.channel }}
ref: ${{ inputs.ref || github.ref }}
limit-win-builds: ${{ inputs.limit-win-builds }}

linux:
if: inputs.os == 'linux' || inputs.os == 'all'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/validate-nightly-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ jobs:
with:
channel: nightly
os: all
limit-win-builds: enable
1 change: 1 addition & 0 deletions .github/workflows/validate-release-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ jobs:
with:
channel: release
os: all
limit-win-builds: enable
10 changes: 10 additions & 0 deletions .github/workflows/validate-windows-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ on:
default: ""
required: false
type: string
limit-win-builds:
description: "Limit windows builds to single python/cuda config"
default: "disable"
type: string
workflow_dispatch:
inputs:
channel:
Expand All @@ -28,6 +32,11 @@ on:
default: ""
required: false
type: string
limit-win-builds:
description: "Limit windows builds to single python/cuda config"
default: "disable"
required: false
type: string

jobs:
generate-windows-matrix:
Expand All @@ -36,6 +45,7 @@ jobs:
package-type: all
os: windows
channel: ${{ inputs.channel }}
limit-win-builds: ${{ inputs.limit-win-builds }}

win:
needs: generate-windows-matrix
Expand Down