Skip to content

Upgrade cmake version to 3.22.1 to build triton #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Upgrade cmake version to 3.22.1 to build triton #1331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9729c8d
Upgrade cmake version to 3.22.1 to build triton
huydhn Mar 6, 2023
871ac9d
Pin patcheft version
huydhn Mar 6, 2023
0cd3b66
Fix comment typo
huydhn Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion common/install_conda.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,7 @@ chmod +x Miniconda3-latest-Linux-x86_64.sh
bash ./Miniconda3-latest-Linux-x86_64.sh -b -p /opt/conda
rm Miniconda3-latest-Linux-x86_64.sh
export PATH=/opt/conda/bin:$PATH
conda install -y conda-build anaconda-client git ninja
# cmake-3.22.1 from conda, same as the one used by PyTorch CI. The system cmake
# is too old to build triton
conda install -y conda-build anaconda-client git ninja cmake=3.22.1
conda remove -y --force patchelf
4 changes: 3 additions & 1 deletion common/install_patchelf.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

set -ex

git clone https://github.com/NixOS/patchelf
# Pin the version to latest release 0.17.2, building newer commit starts
# to fail on the current image
git clone -b 0.17.2 --single-branch https://github.com/NixOS/patchelf
cd patchelf
sed -i 's/serial/parallel/g' configure.ac
./bootstrap.sh
Expand Down
5 changes: 3 additions & 2 deletions manywheel/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@ RUN wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm &
rpm -ivh epel-release-latest-7.noarch.rpm && \
rm -f epel-release-latest-7.noarch.rpm

# cmake-3.18.4 from pip
# cmake-3.22.1 from pip, same as the one used by PyTorch CI. cmake-3.18.4 is
# too old to build triton now
RUN yum install -y python3-pip && \
python3 -mpip install cmake==3.18.4 && \
python3 -mpip install cmake==3.22.1 && \
ln -s /usr/local/bin/cmake /usr/bin/cmake

RUN yum install -y autoconf aclocal automake make
Expand Down