-
Notifications
You must be signed in to change notification settings - Fork 228
aarch64: cd: remove conda dependency #1781
base: main
Are you sure you want to change the base?
Conversation
No ciflow labels are configured for this repo. |
bc22d0b
to
ea47b0d
Compare
@snadampal please open PR in pytorch/pytorch to test this change. Similar to this one: |
aecee1a
to
2fa4a66
Compare
122870d
to
d7ec206
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it tries to do two things at once: update docker and get rid of conda dependencies. With that in mind, do you mind splitting it into two (especially if you want to cherry-pick the libomp fix into 2.3 branch, as migration from manylinux2014 to manylinux2_28 is to big of a change to be accepted into release branch)
sure, I will split. but, as you know I migrated to manylinux2_28 so that it comes with all the packages that we were relying on conda earlier. |
Sorry, I might have missed the conversation. What packages do you need from 2_28, that you can not install in manylinux2014 from pypi instead of conda? |
to start with, python3.10 itself, even the source builds were failing. probably if I spend more time, I will be able to figure out some workaround, but given manylinux 2014 EOL is June 30th, 2024, I have opted for manylinux 2_28. |
libomp issue with the current CD is addressed in this PR: #1787
Once the above PR is merged, I will rebase and split the current PR into two steps for the below feature.
|
d7ec206
to
ba62132
Compare
this solves the libomp performance issues.
fixes: #1774