Update s390x builder #1802
Update s390x builder #1802
Conversation
There is a not yet investigated build failure caused by gcc 12, but it doesn't reproduce with gcc 13.
| @@ -137,18 +137,3 @@ jobs: | |||
| - name: Build Docker Image | |||
| run: | | |||
| manywheel/build_docker.sh | |||
| build-docker-cpu-s390x: | |||
There was a problem hiding this comment.
Is this a correct understanding that we can now remove this and let Docker pull figure out the correct CPU arch (s390x) corresponding to this change pytorch/pytorch@2928b2c?
There was a problem hiding this comment.
No, since I couldn't find where I could download built image for s390x, I just built it manually and backed it into my github actions runner docker image. So it's available locally and isn't needed to be built. I'm also fine with actually building it here and downloading it by actions runner, if it's publicly available somewhere.
| @@ -1,18 +1,15 @@ | |||
| FROM --platform=linux/s390x docker.io/redhat/ubi9 as base | |||
| FROM --platform=linux/s390x docker.io/ubuntu:24.04 as base | |||
There was a problem hiding this comment.
Note: If it works, we can stick with ubuntu for now. Otherwise, let's use AlmaLinux 8 as mentioned in https://github.com/pypa/manylinux per our discussion.
| @@ -15,7 +15,7 @@ case "${GPU_ARCH_TYPE:-BLANK}" in | |||
| rocm) | |||
| bash "${SCRIPTPATH}/build_rocm.sh" | |||
| ;; | |||
| cpu | cpu-cxx11-abi) | |||
| cpu | cpu-cxx11-abi | cpu-s390x) | |||
There was a problem hiding this comment.
Should cpu-s390x be removed from here too?
There was a problem hiding this comment.
No, with this change, I can remove commit pytorch/pytorch@2928b2c
Or I can also drop this change and keep it as just "cpu" for s390x. But for aarch64 "cpu-aarch64" is used, so I did similar "cpu-s390x" for s390x.
* Disable automatic building of s390x docker image * Update docker image and build scripts for s390x * Switch devtoolset to 13 There is a not yet investigated build failure caused by gcc 12, but it doesn't reproduce with gcc 13. * Adapt binaries check for s390x * Switch to ubuntu:24.04 for s390x * Update libgomp.so.1 path for s390x
Update binary checks for s390x build