Skip to content

Don't deactivate/remove conda on linux after validation #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024
Merged

Don't deactivate/remove conda on linux after validation #1814

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef8bcea
Don't deactivate/remove conda on linux
atalman May 7, 2024
f54b780
test
atalman May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/scripts/validate_binaries.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ else
${PWD}/check_binary.sh
fi

# We are only interested in CUDA tests and Python 3.8-3.11. Not all requirement libraries are available for 3.12 yet.
if [[ ${INCLUDE_TEST_OPS:-} == 'true' && ${MATRIX_GPU_ARCH_TYPE} == 'cuda' && ${MATRIX_PYTHON_VERSION} != "3.12" ]]; then
source ./.github/scripts/validate_test_ops.sh
fi

if [[ ${TARGET_OS} == 'windows' ]]; then
python ./test/smoke_test/smoke_test.py ${TEST_SUFFIX}
else
Expand All @@ -64,13 +69,8 @@ else
export PATH=${OLD_PATH}
fi

# We are only interested in CUDA tests and Python 3.8-3.11. Not all requirement libraries are available for 3.12 yet.
if [[ ${INCLUDE_TEST_OPS:-} == 'true' && ${MATRIX_GPU_ARCH_TYPE} == 'cuda' && ${MATRIX_PYTHON_VERSION} != "3.12" ]]; then
source ./.github/scripts/validate_test_ops.sh
fi

# TODO: remove if statement currently this step is timing out on linx-aarch64
if [[ ${TARGET_OS} != 'linux-aarch64' ]]; then
# this is optional step
if [[ ${TARGET_OS} != linux* ]]; then
conda deactivate
conda env remove -n ${ENV_NAME}
fi
Expand Down
Loading