Skip to content

[Validations] Add option to use meta cdn for pypi index #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2024
Merged

[Validations] Add option to use meta cdn for pypi index #1999

merged 3 commits into from
Sep 27, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Sep 27, 2024

No description provided.

tinsingcheong
tinsingcheong approved these changes Sep 27, 2024
View reviewed changes
Copy link

@tinsingcheong tinsingcheong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp to unblock, just a quick question: how do we know this is only for nightly build? I didn't see specific condition to enable use_meta_cdn or maybe that's in another diff?

@atalman atalman merged commit 536fefe into pytorch:main Sep 27, 2024
20 of 51 checks passed
@atalman atalman deleted the add_meta_cdn_url branch September 27, 2024 14:28
@atalman atalman mentioned this pull request Oct 4, 2024
Merged
atalman added a commit to pytorch/test-infra that referenced this pull request Oct 7, 2024
@atalman
[Temp] Use Meta CDN for building domain binaries (#5747)
333d432 
We already use Meta CDN in builder validation as an option:
pytorch/builder#1999

Here is the log from builder:
```
+++ pip3 install --pre torch torchvision torchaudio --index-url https://d3kup0pazkvub8.cloudfront.net/whl/nightly/cu121
Looking in indexes: https://d3kup0pazkvub8.cloudfront.net/whl/nightly/cu121
Collecting torch
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/cu121/torch-2.6.0.dev20241003%2Bcu121-cp310-cp310-win_amd64.whl (2451.6 MB)
     ---------------------------------------- 2.5/2.5 GB 45.6 MB/s eta 0:00:00
Collecting torchvision
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/cu121/torchvision-0.20.0.dev20241003%2Bcu121-cp310-cp310-win_amd64.whl (6.2 MB)
     ---------------------------------------- 6.2/6.2 MB 31.5 MB/s eta 0:00:00
Collecting torchaudio
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/cu121/torchaudio-2.5.0.dev20241003%2Bcu121-cp310-cp310-win_amd64.whl (4.2 MB)
     ---------------------------------------- 4.2/4.2 MB 31.1 MB/s eta 0:00:00
Collecting filelock (from torch)
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/filelock-3.13.1-py3-none-any.whl (11 kB)
Collecting typing-extensions>=4.8.0 (from torch)
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/typing_extensions-4.12.2-py3-none-any.whl (37 kB)
Collecting networkx (from torch)
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/networkx-3.3-py3-none-any.whl (1.7 MB)
     ---------------------------------------- 1.7/1.7 MB 31.3 MB/s eta 0:00:00
Collecting jinja2 (from torch)
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/Jinja2-3.1.4-py3-none-any.whl (133 kB)
Collecting fsspec (from torch)
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/fsspec-2024.6.1-py3-none-any.whl (177 kB)
Collecting sympy==1.13.1 (from torch)
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/sympy-1.13.1-py3-none-any.whl (6.2 MB)
     ---------------------------------------- 6.2/6.2 MB 53.9 MB/s eta 0:00:00
Collecting mpmath<1.4,>=1.1.0 (from sympy==1.13.1->torch)
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/mpmath-1.3.0-py3-none-any.whl (536 kB)
     ------------------------------------- 536.2/536.2 kB 17.1 MB/s eta 0:00:00
Requirement already satisfied: numpy in c:\jenkins\miniconda3\envs\conda-env-11165033321\lib\site-packages (from torchvision) (2.0.1)
Collecting pillow!=8.3.*,>=5.3.0 (from torchvision)
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/Pillow-9.3.0-cp310-cp310-win_amd64.whl (2.5 MB)
     ---------------------------------------- 2.5/2.5 MB 146.9 MB/s eta 0:00:00
Collecting MarkupSafe>=2.0 (from jinja2->torch)
  Downloading https://d3kup0pazkvub8.cloudfront.net/whl/nightly/MarkupSafe-2.1.5-cp310-cp310-win_amd64.whl (17 kB)
Installing collected packages: mpmath, typing-extensions, sympy, pillow, networkx, MarkupSafe, fsspec, filelock, jinja2, torch, torchvision, torchaudio```
kit1980 added a commit to pytorch/pytorch.github.io that referenced this pull request Oct 30, 2024
@kit1980
Remove ref from validate-quick-start-module.yml
ff8de10 
As ref was removed from pytorch/builder/.github/workflows/validate-binaries.yml in pytorch/builder#1999
@kit1980 kit1980 mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinsingcheong tinsingcheong tinsingcheong approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atalman @tinsingcheong @facebook-github-bot