Skip to content

Commit 71944e9

Browse files
ejguanfacebook-github-bot
authored andcommitted
Temporarily revert awssdk on linux (#423)
Summary: Due to AWSSDK requires libcrypto, which is not included manylinux standard, the linux binary breaks TorchVision's CI. I am reverting awssdk built for linux before I figure out make `libcrypto` and `libssl` all statically linked to aws and packaged into TorchData. Pull Request resolved: #423 Reviewed By: NivekT Differential Revision: D36515521 Pulled By: ejguan fbshipit-source-id: b0419aef3100d6a98a030916c6ce9385514e3ef2
1 parent 42922cf commit 71944e9

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

.github/workflows/_build_test_upload.yml

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
wheel_build_test:
5353
needs: get_release_type
5454
runs-on: ${{ matrix.os }}
55-
container: ${{ startsWith( matrix.os, 'ubuntu' ) && 'quay.io/pypa/manylinux2014_x86_64' || null }}
55+
# container: ${{ startsWith( matrix.os, 'ubuntu' ) && 'quay.io/pypa/manylinux2014_x86_64' || null }}
5656
strategy:
5757
fail-fast: false
5858
matrix:
@@ -67,7 +67,7 @@ jobs:
6767
- "3.10"
6868
steps:
6969
- name: Setup Python ${{ matrix.python-version }}
70-
if: ${{ ! startsWith( matrix.os, 'ubuntu' ) }}
70+
# if: ${{ ! startsWith( matrix.os, 'ubuntu' ) }}
7171
uses: actions/setup-python@v2
7272
with:
7373
python-version: ${{ matrix.python-version }}
@@ -87,33 +87,33 @@ jobs:
8787
- name: Install Build Dependency
8888
shell: bash
8989
run: |
90-
if ${{ startsWith( matrix.os, 'ubuntu' ) }}; then
91-
yum -y install ninja-build
92-
yum -y install openssl-devel openssl-static curl-devel zlib-devel
93-
else
94-
pip install cmake ninja
95-
echo "/home/runner/.local/bin" >> $GITHUB_PATH
96-
fi
90+
# if ${{ startsWith( matrix.os, 'ubuntu' ) }}; then
91+
# yum -y install ninja-build
92+
# yum -y install openssl-devel openssl-static curl-devel zlib-devel
93+
# else
94+
pip install cmake ninja
95+
echo "/home/runner/.local/bin" >> $GITHUB_PATH
96+
# fi
9797
- name: Install PyTorch and Build TorchData Wheel
9898
shell: bash
9999
env:
100100
PYTHON_VERSION: ${{ matrix.python-version }}
101101
PYTORCH_VERSION: ${{ inputs.pytorch_version }}
102-
BUILD_S3: 1
102+
BUILD_S3: ${{ startsWith( matrix.os, 'ubuntu' ) && 'OFF' || 'ON' }}
103103
run: |
104-
if ${{ startsWith( matrix.os, 'ubuntu' ) }}; then
105-
# See: https://github.com/actions/checkout/issues/760
106-
git config --global --add safe.directory /__w/data/data
107-
source packaging/manylinux_wheel_helper.sh
108-
fi
104+
# if ${{ startsWith( matrix.os, 'ubuntu' ) }}; then
105+
# # See: https://github.com/actions/checkout/issues/760
106+
# git config --global --add safe.directory /__w/data/data
107+
# source packaging/manylinux_wheel_helper.sh
108+
# fi
109109
packaging/build_wheel.sh
110110
- name: Validate TorchData Wheel
111111
shell: bash
112112
env:
113113
PYTHON_VERSION: ${{ matrix.python-version }}
114114
run: |
115115
if ${{ startsWith( matrix.os, 'ubuntu' ) }}; then
116-
source packaging/manylinux_wheel_helper.sh
116+
# source packaging/manylinux_wheel_helper.sh
117117
pip3 install auditwheel
118118
fi
119119
pip3 install pkginfo
@@ -129,18 +129,18 @@ jobs:
129129
env:
130130
PYTHON_VERSION: ${{ matrix.python-version }}
131131
run: |
132-
if ${{ startsWith( matrix.os, 'ubuntu' ) }}; then
133-
source packaging/manylinux_wheel_helper.sh
134-
fi
132+
# if ${{ startsWith( matrix.os, 'ubuntu' ) }}; then
133+
# source packaging/manylinux_wheel_helper.sh
134+
# fi
135135
pip3 install dist/torchdata*.whl
136136
- name: Run DataPipes Tests with pytest
137137
shell: bash
138138
env:
139139
PYTHON_VERSION: ${{ matrix.python-version }}
140140
run: |
141-
if ${{ startsWith( matrix.os, 'ubuntu' ) }}; then
142-
source packaging/manylinux_wheel_helper.sh
143-
fi
141+
# if ${{ startsWith( matrix.os, 'ubuntu' ) }}; then
142+
# source packaging/manylinux_wheel_helper.sh
143+
# fi
144144
pip3 install expecttest fsspec iopath==0.1.9 numpy pytest rarfile protobuf
145145
pytest --no-header -v test --ignore=test/test_period.py --ignore=test/test_text_examples.py --ignore=test/test_audio_examples.py
146146
- name: Upload Wheels to Github

0 commit comments

Comments
 (0)