Skip to content

Temporarily revert awssdk on linux #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Temporarily revert awssdk on linux #423

wants to merge 1 commit into from

Conversation

ejguan
Copy link
Contributor

@ejguan ejguan commented May 19, 2022

Due to AWSSDK requires libcrypto, which is not included manylinux standard, the linux binary breaks TorchVision's CI.

I am reverting awssdk built for linux before I figure out make libcrypto and libssl all statically linked to aws and packaged into TorchData.

See: #418

@ejguan ejguan requested review from VitalyFedyunin and NivekT May 19, 2022 14:00
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2022
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ejguan ejguan mentioned this pull request May 19, 2022
facebook-github-bot pushed a commit that referenced this pull request May 19, 2022
Summary:
Follow up for #423

Pull Request resolved: #424

Reviewed By: NivekT

Differential Revision: D36516526

Pulled By: ejguan

fbshipit-source-id: 93287442cb1f96f6910f67935b03577a4edaf1d8
@ejguan ejguan deleted the revert_linux branch May 23, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants