Skip to content

Updating test code to follow single iterator constraint #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented May 5, 2022

Stack from ghstack:

This should be landed after pytorch/pytorch#75995

Note that the CI is expected to fail until that PR goes into nightly

Differential Revision: D36182556

NivekT added a commit that referenced this pull request May 5, 2022
ghstack-source-id: 470e9da
Pull Request resolved: #386
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2022
@NivekT
Copy link
Contributor Author

NivekT commented May 5, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@NivekT NivekT marked this pull request as draft May 5, 2022 22:16
This should be landed after pytorch/pytorch#75995

Note that the CI is expected to fail until that PR lands

Differential Revision: [D36182556](https://our.internmc.facebook.com/intern/diff/D36182556)

[ghstack-poisoned]
@NivekT NivekT marked this pull request as ready for review May 18, 2022 21:35
@NivekT NivekT requested review from ejguan and VitalyFedyunin May 18, 2022 21:35
This should be landed after pytorch/pytorch#75995

Note that the CI is expected to fail until that PR goes into nightly

Differential Revision: [D36182556](https://our.internmc.facebook.com/intern/diff/D36182556)

[ghstack-poisoned]
@ejguan
Copy link
Contributor

ejguan commented May 19, 2022

It seems PyTorch nightly has been updated. This PR can be landed otherwise all DataPipe tests become red.

@NivekT
Copy link
Contributor Author

NivekT commented May 19, 2022

Yea, but the issue with GHA is that even though nightly has landed, the internal diff hasn't, and my diff (D36182556) is dependent on the internal one landing first.

The options are:

  1. Remove the dependencies from D36182556 and land this (it won't pass the internal test, because the other stack hasn't landed yet)
  2. Wait for the other stack of diffs to land, then land this one (D36182556)

@ejguan
Copy link
Contributor

ejguan commented May 19, 2022

Oh. I don't realize such problem, good to know. Let's wait until internal Diff landed. (Decoupling is more important now)

@ejguan
Copy link
Contributor

ejguan commented May 19, 2022

If the whole stack of PRs in PT Core got reverted because the failed internal tests for TorchData, you might need to combine this PR with the PR in PyTorch core in a single Diff and land it from internal Phabricator.

This should be landed after pytorch/pytorch#75995

Note that the CI is expected to fail until that PR goes into nightly

Differential Revision: [D36182556](https://our.internmc.facebook.com/intern/diff/D36182556)

[ghstack-poisoned]
@NivekT
Copy link
Contributor Author

NivekT commented May 19, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/76/head branch May 23, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants