-
Notifications
You must be signed in to change notification settings - Fork 166
Updating test code to follow single iterator constraint #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This should be landed after pytorch/pytorch#75995 Note that the CI is expected to fail until that PR lands Differential Revision: [D36182556](https://our.internmc.facebook.com/intern/diff/D36182556) [ghstack-poisoned]
This should be landed after pytorch/pytorch#75995 Note that the CI is expected to fail until that PR goes into nightly Differential Revision: [D36182556](https://our.internmc.facebook.com/intern/diff/D36182556) [ghstack-poisoned]
It seems PyTorch nightly has been updated. This PR can be landed otherwise all DataPipe tests become red. |
Yea, but the issue with GHA is that even though nightly has landed, the internal diff hasn't, and my diff (D36182556) is dependent on the internal one landing first. The options are:
|
Oh. I don't realize such problem, good to know. Let's wait until internal Diff landed. (Decoupling is more important now) |
If the whole stack of PRs in PT Core got reverted because the failed internal tests for TorchData, you might need to combine this PR with the PR in PyTorch core in a single Diff and land it from internal Phabricator. |
This should be landed after pytorch/pytorch#75995 Note that the CI is expected to fail until that PR goes into nightly Differential Revision: [D36182556](https://our.internmc.facebook.com/intern/diff/D36182556) [ghstack-poisoned]
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Stack from ghstack:
This should be landed after pytorch/pytorch#75995
Note that the CI is expected to fail until that PR goes into nightly
Differential Revision: D36182556