Enable S3 in nightly release #399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ejguan
force-pushed
the
enable_s3
branch
12 times, most recently
from
4512858 to
ca1fff7
Compare
ejguan
force-pushed
the
enable_s3
branch
3 times, most recently
from
7c07416 to
a8f2c8c
Compare
ejguan
commented
May 16, 2022
Comment on lines
+27
to
+35
| try: | ||
| import google.protobuf as _protobuf | ||
|
|
||
| del _protobuf | ||
| HAS_PROTOBUF = True | ||
| except ImportError: | ||
| HAS_PROTOBUF = False | ||
| skipIfNoPROTOBUF = unittest.skipIf(not HAS_PROTOBUF, "no google protobuf") | ||
|
|
There was a problem hiding this comment.
The changes in test/test_tfrecord.py are introduced because protobuf should be an optional dependency for TorchData test.
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
commented
May 16, 2022
Comment on lines
+9
to
+10
| git config --system core.longpaths true | ||
|
|
There was a problem hiding this comment.
This is required because a few submodules that AWSSDK used have long name for windows system
ejguan
commented
May 16, 2022
Comment on lines
+275
to
+276
| # TODO: Add serialization tests for optional DataPipe | ||
| # (iterdp.TFRecordLoader, None, (), {}), |
bearzx
reviewed
May 16, 2022
test/test_remote_io.py
Outdated
| @@ -1,4 +1,3 @@ | |||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | |||
There was a problem hiding this comment.
Thanks for pointing it out! I have no idea :P
bearzx
approved these changes
May 16, 2022
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #349
This PR enables:
MacOS is disabled because AWSSDK requires
MACOSX_DEPLOYMENT_TARGET>10.13. However, TorchText requires a minimum version ofMACOSX_DEPLOYMENT_TARGETas 10.9 (Tracked in TorchText pytorch/text#1725)And, the conda build on Windows is also disabled for now due to unkown issue (needs more time). Want to land this PR to start testing with TorchText nightly.
See the manually triggered nightly build: https://github.com/pytorch/data/actions/runs/2334403716