-
Notifications
You must be signed in to change notification settings - Fork 166
[DataPipe] Adding a 's' to the functional names of open/list DataPipes #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this PR. Could you please also fix tests?
I don't think there are any existing use cases in tests but I have added some. |
…st DataPipes" [ghstack-poisoned]
…st DataPipes" [ghstack-poisoned]
# Register for functional API for backward compatibility | ||
IterDataPipe.register_datapipe_as_function("open_file_by_fsspec", FSSpecFileOpenerIterDataPipe) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow-up task, add deprecation warning for the functional API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we will need to change the registration function and IterDataPipe
class in PyTorch core to do that. One possibility is described here.
Do you think we should land this PR as it is or make the changes to core first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land this PR first and change the core afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, could you please update the deprecation table as well?
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: #479 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D36785643 Pulled By: NivekT fbshipit-source-id: 02c3071047ac00dd34cb83a9b392be0cfa3565b0
) Summary: Pull Request resolved: pytorch#479 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D36785643 Pulled By: NivekT fbshipit-source-id: 02c3071047ac00dd34cb83a9b392be0cfa3565b0
Stack from ghstack:
Differential Revision: D36785643