Skip to content

Commit d52cefd

Browse files
author
zhenyanzhang
committed
Update on "[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type"
Following #9971 - Update get_flatbuffer_scalar_type return type to Result<T> - Iteratively update functions that calling the functions with result type changed: - Check returns, if with an error, pass above the error. - If unable to pass error, update the return type as Result<T> Differential Revision: [D72771753](https://our.internmc.facebook.com/intern/diff/D72771753/) [ghstack-poisoned]
1 parent 6e72390 commit d52cefd

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

runtime/core/event_tracer.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,9 @@ class EventTracer {
313313
* @param[in] evalue The value to be logged.
314314
* @param[in] evalue_type Indicates what type of output this is logging e.g.
315315
* an intermediate output, program output etc.
316+
* @return A Result<bool> indicating the status of the logging operation.
317+
* - True if the evalue output was successfully logged.
318+
* - An error code if an error occurs during logging.
316319
*/
317320
virtual Result<bool> log_evalue(
318321
const EValue& evalue,

0 commit comments

Comments
 (0)