Skip to content

[Request impl] Gracefully error out in ETDump #9971

Open
@Gasoonjia

Description

@Gasoonjia
Contributor

Context and Target:

In the etdump_flatcc.cpp file, there are instances where the class may directly raise an error and shut down the system when encountering issues. An example can be found here.
The preferred approach is to handle these errors gracefully by returning an error code to the user, allowing them to decide how to address the issue.

TODO:

  • Modify the code to return an error code to the user instead of crashing the system when an error occurs.
    If applicable, use the ET_CHECK_OR_RETURN_ERROR macro, as seen here.
    Alternatively, manually return an error code, as demonstrated here, if there's extra work like free need to be done.

  • Update the return type of the function as necessary and ensure corresponding tests are updated.

Consider breaking this task into two or three pull requests for better structure and clarity.

Activity

added a commit that references this issue on Apr 10, 2025

[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type

added 3 commits that reference this issue on Apr 10, 2025

[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type

Update on "[#9971] Gracefully error out in ETDump for get_flatbuffer_…

[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type

added a commit that references this issue on Apr 10, 2025

[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type

2c49165
added 2 commits that reference this issue on Apr 10, 2025

[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type (

2ed44ce

[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type (

zhongmingyuan

zhongmingyuan commented on Apr 12, 2025

@zhongmingyuan
Contributor

I want to work on it as a learning opportunity. May I take this issue?

zhenyan-zhang-meta

zhenyan-zhang-meta commented on Apr 12, 2025

@zhenyan-zhang-meta
Contributor

@zhongmingyuan Please take it, reference my PR as a good starting point. Can add @Gasoonjia and me as reviewers.

added a commit that references this issue on Apr 14, 2025

[#9971] Gracefully error out in ETDump for set_debug_buffer (#10130)

1eb9546
added
triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
on Apr 14, 2025
added 2 commits that reference this issue on Apr 21, 2025

[pytorch#9971] Gracefully error out in ETDump for get_flatbuffer_scal…

[pytorch#9971] Gracefully error out in ETDump for set_debug_buffer (p…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

good first issueGood for newcomersmodule: devtoolsIssues related to developer tools and code under devtools/triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @zhongmingyuan@GregoryComer@Gasoonjia@zhenyan-zhang-meta

      Issue actions

        [Request impl] Gracefully error out in ETDump · Issue #9971 · pytorch/executorch