Description
Context and Target:
In the etdump_flatcc.cpp
file, there are instances where the class may directly raise an error and shut down the system when encountering issues. An example can be found here.
The preferred approach is to handle these errors gracefully by returning an error code to the user, allowing them to decide how to address the issue.
TODO:
-
Modify the code to return an error code to the user instead of crashing the system when an error occurs.
If applicable, use theET_CHECK_OR_RETURN_ERROR
macro, as seen here.
Alternatively, manually return an error code, as demonstrated here, if there's extra work likefree
need to be done. -
Update the return type of the function as necessary and ensure corresponding tests are updated.
Consider breaking this task into two or three pull requests for better structure and clarity.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Activity
[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type
[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type
Update on "[#9971] Gracefully error out in ETDump for get_flatbuffer_…
[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type
[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type
[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type (…
[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type (…
zhongmingyuan commentedon Apr 12, 2025
I want to work on it as a learning opportunity. May I take this issue?
zhenyan-zhang-meta commentedon Apr 12, 2025
@zhongmingyuan Please take it, reference my PR as a good starting point. Can add @Gasoonjia and me as reviewers.
[#9971] Gracefully error out in ETDump for set_debug_buffer (#10130)
[pytorch#9971] Gracefully error out in ETDump for get_flatbuffer_scal…
[pytorch#9971] Gracefully error out in ETDump for set_debug_buffer (p…