Skip to content

Conversation

perheld
Copy link
Collaborator

@perheld perheld commented Apr 10, 2025

Test_arm_baremetal.sh didnt warn about missing setup_path.sh like other scripts. This patch makes it more like others.

Change-Id: I124df660ce873d98fd067ce2441a396ac3c183fc

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@perheld perheld requested a review from digantdesai as a code owner April 10, 2025 06:57
Copy link

pytorch-bot bot commented Apr 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10057

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 2aa6c40 with merge base 8d8f677 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2025
@perheld perheld added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing labels Apr 10, 2025
@perheld
Copy link
Collaborator Author

perheld commented Apr 10, 2025

@pytorchbot label ciflow/trunk

@perheld
Copy link
Collaborator Author

perheld commented Apr 10, 2025

Strange error. FAILED backends/arm/test/models/test_torch_functions.py::test_torch_fns_MI[norm] - Exception: An error occurred when running the 'KeepDimsFalseToSqueezePass' pass after the following passes:

I cant see how its related.

@zingo
Copy link
Collaborator

zingo commented Apr 10, 2025

The error might go away when #10043 is merged

Test_arm_baremetal.sh didnt warn about missing setup_path.sh like
other scripts. This patch makes it more like others.

Change-Id: I124df660ce873d98fd067ce2441a396ac3c183fc
@zingo zingo merged commit c8a2211 into pytorch:main Apr 11, 2025
167 of 169 checks passed
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
Test_arm_baremetal.sh didnt warn about missing setup_path.sh like other
scripts. This patch makes it more like others.
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
Test_arm_baremetal.sh didnt warn about missing setup_path.sh like other
scripts. This patch makes it more like others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants