[ET-VK][ez] Support convolutions with padding > 0 and dilation > 1 #10148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request resolved: #10115 ## Context As title. ## Changes Modified convolution shader to set starting input position correctly when padding and dilation are both greater than 0. Removed safeguard check for padding = 0 when dilation > 1 in C++ implementation. Differential Revision: [D72879342](https://our.internmc.facebook.com/intern/diff/D72879342/) ghstack-source-id: 277982652
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10148
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 48 PendingAs of commit 09aa4da with merge base c352672 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
SS-JIA
approved these changes
Apr 14, 2025
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
…ytorch#10148) ## Context As title. ## Changes Modified convolution shader to set starting input position correctly when padding and dilation are both greater than 0. Removed safeguard check for padding = 0 when dilation > 1 in C++ implementation. Differential Revision: [D72879342](https://our.internmc.facebook.com/intern/diff/D72879342/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #10115 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/211/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/211/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/211/orig
@diff-train-skip-merge