-
Notifications
You must be signed in to change notification settings - Fork 685
import complex.h from c10 #10155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import complex.h from c10 #10155
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10155
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e840037 with merge base d614700 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D72197508 |
This pull request was exported from Phabricator. Differential Revision: D72197508 |
Summary: Pull Request resolved: pytorch#10155 Import complex type and utils from c10 in order to do arithmetic with complex numbers in ExecuTorch kernels. Reviewed By: digantdesai Differential Revision: D72197508
6a64180
to
c530712
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems legit as long as the c10 headers are exact copies
I thought this would be bc-breaking; didn't realize that real_ and imag_ on c10::complex are public.
Summary: Pull Request resolved: pytorch#10155 Import complex type and utils from c10 in order to do arithmetic with complex numbers in ExecuTorch kernels. Reviewed By: digantdesai, swolchok Differential Revision: D72197508
This pull request was exported from Phabricator. Differential Revision: D72197508 |
c530712
to
e840037
Compare
Differential Revision: D72197508 Pull Request resolved: pytorch#10155
Summary: Import complex type and utils from c10 in order to do arithmetic with complex numbers in ExecuTorch kernels.
Reviewed By: digantdesai
Differential Revision: D72197508