Skip to content

Conversation

manuelcandales
Copy link
Contributor

Summary: Import complex type and utils from c10 in order to do arithmetic with complex numbers in ExecuTorch kernels.

Reviewed By: digantdesai

Differential Revision: D72197508

Copy link

pytorch-bot bot commented Apr 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10155

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e840037 with merge base d614700 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72197508

@manuelcandales manuelcandales added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Apr 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72197508

manuelcandales added a commit to manuelcandales/executorch-1 that referenced this pull request Apr 14, 2025
Summary:
Pull Request resolved: pytorch#10155

Import complex type and utils from c10 in order to do arithmetic with complex numbers in ExecuTorch kernels.

Reviewed By: digantdesai

Differential Revision: D72197508
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit as long as the c10 headers are exact copies

I thought this would be bc-breaking; didn't realize that real_ and imag_ on c10::complex are public.

Summary:
Pull Request resolved: pytorch#10155

Import complex type and utils from c10 in order to do arithmetic with complex numbers in ExecuTorch kernels.

Reviewed By: digantdesai, swolchok

Differential Revision: D72197508
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72197508

@facebook-github-bot facebook-github-bot merged commit d020a0d into pytorch:main Apr 15, 2025
82 of 84 checks passed
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
Differential Revision: D72197508

Pull Request resolved: pytorch#10155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants