-
Notifications
You must be signed in to change notification settings - Fork 637
Bump PyTorch nightly pin past April 22, 2025 #10362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10362
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit b8f6b50 with merge base 3066463 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 . ghstack-source-id: 7ef4d5c ghstack-comment-id: 2822111987 Pull-Request-resolved: #10362
"Build documentation / check-urls" failure looks spurious; will rerun when the option becomes available. |
Can we hold on bumping? The PR pytorch/pytorch#151436 merged last week causing 50+ tests failing... |
@cccclai OK please let me know when we can do this |
@tugsbayasgalan is working on resolving the failure. |
ping @cccclai @tugsbayasgalan |
See discussion in #10319 (comment), hopefully it's resolved soon |
#10769 for the fix. |
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 . ghstack-source-id: fbc5600 ghstack-comment-id: 2822111987 Pull-Request-resolved: #10362
looks like we have more breakage if I try to roll forward to the present day. let's go back to at least catching up to April 22 |
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 . ghstack-source-id: ca64709 ghstack-comment-id: 2822111987 Pull-Request-resolved: #10362
#10769 is merged as fyi |
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 . ghstack-source-id: f50a6df ghstack-comment-id: 2822111987 Pull-Request-resolved: #10362
test-llava-runner-linux seems to be consistently failing with SIGILL :( |
Hm, I successfully ran |
if I'm reading correctly, the illegal instruction is a vgf2p8affineqb somewhere in portable_lib. this is an AVX512GFNI instruction which requires at least Ice Lake and the processor in question appears to be Cascade Lake. |
This instruction does seem to be generated in |
the symbol name here may or may not be accurate; I just found that XNNPACK has an avx512vnnigfni configuration |
we are in fact building at least some avx512vnnigfni files per https://github.com/pytorch/executorch/actions/runs/15171458271/job/42808833402?pr=10362 however, this is not new; https://github.com/pytorch/executorch/actions/runs/15218616519/job/42809734929 (a recent trunk run from HUD) also builds them. either 1) we are delegating some op that we weren't delegating before AND XNNPACK's gating for these GFNI kernels was always broken, 2) bumping the pytorch pin somehow magically caused ExecuTorch's copy of XNNPACK to change, or 3) something else I haven't thought of yet. |
This instruction is likely coming from the QB4W gemm kernel. This kernel is only reachable through ET and not PT. Not sure why it is getting activated on a Cascade Lake CPU on the CI C5, esp on a pin bump. At compile time this kernel compilation is gated by XNNPACK_ENABLE_AVX512VNNIGFNI and at runtime it is selected if For now you may try disabling these kernels at compile time, to unblock yourself from updating the pin. I can try to take a closer look next week. Like you, the x86 box I have at hand is also Icelake which supports these. |
…nts), disable XNNPACK_ENABLE_AVX512VNNIGFNI [ghstack-poisoned]
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 . ghstack-source-id: 6c5d261 ghstack-comment-id: 2822111987 Pull-Request-resolved: #10362
failures seem to pattern-match to known issues on main. merging. |
Found the commit hash from https://hud2.pytorch.org/hud/pytorch/pytorch/nightly/0 .