[ExecuTorch][#10364] Add Protected Method Getter in extension.Module
#10374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule # Context This issue is a step of #9638. In the discussion, we want to unblock having `extension/Module` as the single source of implementation, which means that `pybindings/PyModule` should use `extension/Module` rather than its own. Although we are decouping method getter from `pybindings` implementation, method getter itself is still needed. To keep having the method getter while not exposing it, we can create a protected method getter and confine it's usage inside child classes that we are about to create. # Proposal Add a protected `get_method` to `extension.Module`, taking method name string as an input. Differential Revision: [D73473766](https://our.internmc.facebook.com/intern/diff/D73473766/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10374
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit daf2a80 with merge base 95c663e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zhenyan-zhang-meta
pushed a commit
that referenced
this pull request
Apr 22, 2025
…dule # Context This issue is a step of #9638. In the discussion, we want to unblock having `extension/Module` as the single source of implementation, which means that `pybindings/PyModule` should use `extension/Module` rather than its own. Although we are decouping method getter from `pybindings` implementation, method getter itself is still needed. To keep having the method getter while not exposing it, we can create a protected method getter and confine it's usage inside child classes that we are about to create. # Proposal Add a protected `get_method` to `extension.Module`, taking method name string as an input. Differential Revision: [D73473766](https://our.internmc.facebook.com/intern/diff/D73473766/) ghstack-source-id: 279669340 Pull Request resolved: #10374
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73473766 |
facebook-github-bot
merged commit d7dd048
into
gh/zhenyan-zhang-meta/4/base
92 of 96 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
zhenyan-zhang-meta
changed the title
extension.Module
zhenyan-zhang-meta
changed the title
extension.Moduleextension.Module
jackzhxng
pushed a commit
that referenced
this pull request
Apr 24, 2025
…dule (#10384) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #10374 by @zhenyan-zhang-meta ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/zhenyan-zhang-meta/4/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/zhenyan-zhang-meta/4/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/zhenyan-zhang-meta/4/orig @diff-train-skip-merge Co-authored-by: zhenyanzhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
extension.Module#10374Context
This issue is a step of #9638. In the discussion, we want to unblock having
extension/Moduleas the single source of implementation, which means thatpybindings/PyModuleshould useextension/Modulerather than its own.Although we are decouping method getter from
pybindingsimplementation, method getter itself is still needed. To keep having the method getter while not exposing it, we can create a protected method getter and confine it's usage inside child classes that we are about to create.Proposal
Add a protected
get_methodtoextension.Module, taking method name string as an input.Differential Revision: D73473766