Skip to content

[MPS] float16 naming fixed and inexistent mps_logical_not model removed #10562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DenisVieriu97
Copy link
Collaborator

Upstream mps fixes by @versi379

Summary of changes:

  • Updated generated model name in MPS Backend documentation.
  • Removed extra line running an inexistent model when building mps_executor_runner.

cc @cccclai , @shoumikhin

Copy link

pytorch-bot bot commented Apr 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10562

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit cff952d with merge base d2d2bf6 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 29, 2025
@DenisVieriu97 DenisVieriu97 force-pushed the dev/denis/upstream_giovanni_mps-backend-updates branch from 87762b7 to cff952d Compare May 1, 2025 04:17
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cccclai cccclai merged commit 7f5229f into pytorch:main May 1, 2025
97 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants