Skip to content

[ET-VK][ez] Use standard quant naming scheme for quantized ops #10587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Apr 30, 2025

Stack from ghstack (oldest at bottom):

Context

Use standard naming scheme for quantized operators introduced in the previous PR.

For weight only quantized linear operators, the names introduced are:

linear_qcsnw:

  • q - quantized
  • c - per-channel / channelswise
  • s - symmetric
  • n - number of bits (qcs4w for 4-bit quant, qcs8w for 8-bit quant)
  • w - weight quantized

linear_qga4w:

  • q - quantized
  • g - per-group / groupwise
  • a - affine
  • 4 - quantized to 4 bits
  • w - weight quantized

Changes

Rename instances of q_8w_linear to linear_qcs8w or linear_qcsnw.

Rename instances of q_4w_linear to linear_qga4w.

Rename cpp files to match the new naming convention.

Differential Revision: D73941992

## Context

Use standard naming scheme for quantized operators introduced in the previous PR.

For weight only quantized linear operators, the names introduced are:

`linear_qcsnw`:

* q - quantized
* c - per-channel / channelswise
* s - symmetric
* n - number of bits (qcs4w for 4-bit quant, qcs8w for 8-bit quant)
* w - weight quantized

`linear_qga4w`:

* q - quantized
* g - per-group / groupwise
* a - affine
* 4 - quantized to 4 bits
* w - weight quantized

## Changes

Rename instances of `q_8w_linear` to `linear_qcs8w` or `linear_qcsnw`.

Rename instances of `q_4w_linear` to `linear_qga4w`.

Rename cpp files to match the new naming convention.

Differential Revision: [D73941992](https://our.internmc.facebook.com/intern/diff/D73941992/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10587

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit f23c350 with merge base 280db15 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 30, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73941992

… ops"

## Context

Use standard naming scheme for quantized operators introduced in the previous PR.

For weight only quantized linear operators, the names introduced are:

`linear_qcsnw`:

* q - quantized
* c - per-channel / channelswise
* s - symmetric
* n - number of bits (qcs4w for 4-bit quant, qcs8w for 8-bit quant)
* w - weight quantized

`linear_qga4w`:

* q - quantized
* g - per-group / groupwise
* a - affine
* 4 - quantized to 4 bits
* w - weight quantized

## Changes

Rename instances of `q_8w_linear` to `linear_qcs8w` or `linear_qcsnw`.

Rename instances of `q_4w_linear` to `linear_qga4w`.

Rename cpp files to match the new naming convention.

Differential Revision: [D73941992](https://our.internmc.facebook.com/intern/diff/D73941992/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73941992

@SS-JIA SS-JIA added the release notes: vulkan Changes to the Vulkan backend delegate label May 1, 2025
@facebook-github-bot facebook-github-bot merged commit 28bc8e0 into gh/SS-JIA/221/base May 1, 2025
84 of 88 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/SS-JIA/221/head branch May 1, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants