Replace usage of deprecated distutils.(file|dir)_util
#10590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: reverted in D73942429 because of S515958 > `distutils.dir_util.copy_tree` works fine if the target directory exists, but `shutil.copytree` fails by default, unless we pass in `dirs_exist_ok=True` Differential Revision: D73945977
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10590
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b12c587 with merge base 4524838 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73945977 |
|
@pytorchbot label "topic: not user facing" |
mergennachin
approved these changes
May 1, 2025
facebook-github-bot
pushed a commit
to facebook/FAI-PEP
that referenced
this pull request
May 1, 2025
Summary: X-link: pytorch/executorch#10590 reverted in D73942429 because of S515958 > `distutils.dir_util.copy_tree` works fine if the target directory exists, but `shutil.copytree` fails by default, unless we pass in `dirs_exist_ok=True` Reviewed By: mergennachin, itamaro Differential Revision: D73945977 fbshipit-source-id: 6a88ac89e98eae72bcf7f875cf0d4302b6edacbf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
reverted in D73942429 because of S515958
Differential Revision: D73945977