Skip to content

Update doc-build.yml #10596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

Update doc-build.yml #10596

merged 2 commits into from
May 1, 2025

Conversation

metascroy
Copy link
Contributor

Add ability to build docs with manual workflow

Copy link

pytorch-bot bot commented Apr 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10596

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 27065d0 with merge base 771588a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 30, 2025
@metascroy metascroy marked this pull request as ready for review April 30, 2025 21:56
@metascroy metascroy requested a review from mergennachin April 30, 2025 21:56
@metascroy metascroy requested a review from kirklandsign April 30, 2025 22:10
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is workflow_dispatch?

@metascroy
Copy link
Contributor Author

workflow_dispatch

I think it corresponds to the "run workflow" button under actions in the github web UI. Maybe @kirklandsign can confirm?

@kirklandsign
Copy link
Contributor

workflow_dispatch

I think it corresponds to the "run workflow" button under actions in the github web UI. Maybe @kirklandsign can confirm?

That's correct. Have you validated? Different trigger has different ref names

@metascroy metascroy merged commit b9ebff1 into release/0.6 May 1, 2025
79 checks passed
@metascroy metascroy deleted the metascroy-patch-2 branch May 1, 2025 17:30
@metascroy metascroy mentioned this pull request May 1, 2025
metascroy added a commit that referenced this pull request May 1, 2025
After #10596, upload_doc job
runs on manual flow, but doesn't do anything. This change is meant to
change that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants