LlamaDemo Android add Qwen 3 prompt format #10624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10624
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 5 PendingAs of commit 24ae058 with merge base 82c42b6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
shoumikhin
approved these changes
May 1, 2025
kirklandsign
added
topic: not user facing
module: examples
shoumikhin
approved these changes
May 1, 2025
kirklandsign
added
the
release notes: examples
jackzhxng
changed the title
jackzhxng
reviewed
May 1, 2025
| @@ -69,6 +79,8 @@ public static String getStopToken(ModelType modelType) { | |||
| return "<|eot_id|>"; | |||
| case LLAVA_1_5: | |||
| return "</s>"; | |||
| case QWEN_3: | |||
| return "<|im_end|>"; | |||
There was a problem hiding this comment.
stop token should be "<|endoftext|>"
jhelsby
pushed a commit
to jhelsby/executorch
that referenced
this pull request
May 9, 2025
Format the raw prompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mergennachin @iseeyuan @lucylq @helunwencser @tarun292 @kimishpatel @jackzhxng