[ET-VK][Ops] dequantize_per_token.default test setup #11482

ahmtox · 2025-06-09T15:05:01Z

Stack from ghstack (oldest at bottom):

Creating dequantize_per_token testing framework along with a reference implementation for testing

Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

pytorch-bot · 2025-06-09T15:05:04Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11482

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 5 Cancelled Jobs, 10 Unrelated Failures

As of commit ba8f6de with merge base 8cfa858 ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
Lint / link-check / lint-xrefs / linux-job (gh)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

CANCELLED JOBS - The following jobs were cancelled. Please retry:

Lint / link-check / lint-urls / linux-job (gh)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / test-binary-size-linux / linux-job (gh)
pull / test-binary-size-linux-gcc / linux-job (gh)
pull / test-openvino-linux / linux-job (gh)
pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-llama-runner-linux (bf16, custom, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / test-models-linux (add_mul, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / test-models-linux (add, portable, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / test-models-linux (ic3, portable, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / test-models-linux (resnet18, portable, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / test-models-linux-basic (vit, portable, cmake, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / test-moshi-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / test-setup-linux-gcc / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / unittest-buck / linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-06-09T15:06:47Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-09T15:10:41Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-11T17:02:09Z

This pull request was exported from Phabricator. Differential Revision: D76267037

manuelcandales · 2025-06-11T18:45:10Z

backends/vulkan/test/op_tests/dequantize_test.cpp

+  ASSERT_TRUE(output_correct);
+}
+
+// Test cases for dequantize_per_token


any reason why you don't have int32 and int64 tests here?

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-11T19:01:59Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-11T21:51:09Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T14:53:03Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T17:01:21Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T17:05:47Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T19:51:33Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-13T04:15:36Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-13T15:15:31Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-13T18:04:54Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot · 2025-06-13T22:51:24Z

This pull request was exported from Phabricator. Differential Revision: D76267037

Pull Request resolved: pytorch/executorch#11482 # Context In order to enhance my own understanding of these operators, I needed to create a reference implementation, and also build out the vulkan testing framework which creates the necessary build up when I need to call the vulkan implementations. I won't explain what the dequantize operator actually is in this diff, but will rather opt to explain the operator in a future diff where I implement the glsl shader, however, the reference implementation is heavily inspired by the cpu implementation and aims to create similar checks when using the zero points and scales and performing the dequantization with the given parameters. # Changes The main changes were the include of the reference implementation that is used for my own learning, and the necessary wrapper functions that will be called later when the vulkan implementation is successfully completed. It has everything necessary for this purpose, including calling the operator by its appropriate name as when defined in the C++ implementation header, and staging components correctly from the GPU and then the CPU which will be where the comparison is done. I have also included comprehensive failure print statements that prints the tensor size along with relevant parameters such as the zero points or scales passed in. ghstack-source-id: 290376484 @exported-using-ghexport Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/)

[ET-VK][Ops] dequantize_per_token.default test setup

308d957

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

ahmtox requested a review from SS-JIA as a code owner June 9, 2025 15:05

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025

facebook-github-bot added the fb-exported label Jun 9, 2025

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

6626427

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

bd883e5

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

manuelcandales reviewed Jun 11, 2025

View reviewed changes

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

0afd268

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

ahmtox added the release notes: vulkan Changes to the Vulkan backend delegate label Jun 11, 2025

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

e612e25

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

ahmtox mentioned this pull request Jun 11, 2025

[ET-VK][Ops] common test utils for converting aten types to vulkan types #11575

Merged

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

288c3bf

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

5397aa2

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

3ec793f

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

manuelcandales approved these changes Jun 12, 2025

View reviewed changes

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

878be9c

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

31e2755

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

208ddac

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

334872a

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"

ba8f6de

Creating dequantize_per_token testing framework along with a reference implementation for testing Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/) [ghstack-poisoned]

facebook-github-bot merged commit 91df1c4 into gh/ahmtox/15/base Jun 14, 2025
80 of 98 checks passed

facebook-github-bot deleted the gh/ahmtox/15/head branch June 14, 2025 03:46

facebook-github-bot temporarily deployed to cherry-pick-bot June 14, 2025 03:46 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Jun 14, 2025

[ET-VK][Ops] dequantize_per_token.default test setup #11677

Closed

[ET-VK][Ops] dequantize_per_token.default test setup #11482

[ET-VK][Ops] dequantize_per_token.default test setup #11482

Uh oh!

Conversation

ahmtox commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11482

❌ 2 New Failures, 5 Cancelled Jobs, 10 Unrelated Failures

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 11, 2025

Uh oh!

manuelcandales Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 11, 2025

Uh oh!

facebook-github-bot commented Jun 11, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

Uh oh!

Uh oh!

ahmtox commented Jun 9, 2025 •

edited

Loading

pytorch-bot bot commented Jun 9, 2025 •

edited

Loading