[ET-VK][ez] Fix type ambiguity relating to TextureLimits class
#11646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context Fixes build failures in CI by resolving ambiguities with the `TextureLimits` class. ## Changes * Add converting constructor to construct `TextureLimits` from a `utils::uvec3` * Modify `UniformData` class to receive `utils::uvec3` directly, removing the need to reference `TextureLimits` Differential Revision: [D76608702](https://our.internmc.facebook.com/intern/diff/D76608702/) ghstack-source-id: 290281028 Pull Request resolved: #11642
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11646
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 77 Pending, 1 Unrelated FailureAs of commit c747cad with merge base 140cc14 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
JacobSzwejbka
approved these changes
Jun 13, 2025
This PR needs a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11642 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/242/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/242/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/242/orig
@diff-train-skip-merge