Skip to content

Added evaluation script for qualcomm LlamaModel #11663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Added evaluation script for qualcomm LlamaModel #11663

merged 1 commit into from
Jun 16, 2025

Conversation

rohansjoshi
Copy link
Contributor

Summary:
Script for evaluating models which follow qualcomm's LlamaModel definition, on lm eval harness tasks such as WikiText

Results for WikiText evaluation task:

Model Name max_seq_len word_perplexity
Llama 1B Instruct 128 34.82890030691187
Llama 1B Instruct 512 22.919538703371582

Differential Revision: D76634688

@rohansjoshi rohansjoshi requested a review from cccclai as a code owner June 14, 2025 00:49
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11663

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d4f2c9e with merge base 56392aa (image):

NEW FAILURE - The following job has failed:

  • Lint / lintrunner / linux-job (gh)
    RuntimeError: Command docker exec -t b432530c983f21d5f2037dbca211ceb695271704fcc1375a017998d9d78a7742 /exec failed with exit code 127

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76634688

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76634688

rohansjoshi added a commit to rohansjoshi/executorch that referenced this pull request Jun 14, 2025
@rohansjoshi @facebook-github-bot
Added evaluation script for qualcomm LlamaModel (pytorch#11663)
74603d2 
Summary:
Pull Request resolved: pytorch#11663

Script for evaluating models which follow qualcomm's LlamaModel definition, on lm eval harness tasks such as WikiText

Results for WikiText evaluation task:

| Model Name | max_seq_len | word_perplexity
|----------|----------|----------|
| Llama 1B Instruct  | 128   | 34.82890030691187 |
| Llama 1B Instruct  | 512   | 22.919538703371582 |

Differential Revision: D76634688
cccclai
cccclai approved these changes Jun 14, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the eval scripts. @shewu-quic @haowhsu-quic fyi we're adding eval scripts here and trying to improve the accuracy for ptq

@haowhsu-quic
Copy link
Collaborator

Thank you for adding the eval scripts. @shewu-quic @haowhsu-quic fyi we're adding eval scripts here and trying to improve the accuracy for ptq

Thank you, this is very helpful!

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76634688

rohansjoshi added a commit to rohansjoshi/executorch that referenced this pull request Jun 15, 2025
@rohansjoshi @facebook-github-bot
Added evaluation script for qualcomm LlamaModel (pytorch#11663)
7596337 
Summary:
Pull Request resolved: pytorch#11663

Script for evaluating models which follow qualcomm's LlamaModel definition, on lm eval harness tasks such as WikiText

Results for WikiText evaluation task:

| Model Name | max_seq_len | word_perplexity
|----------|----------|----------|
| Llama 1B Instruct  | 128   | 34.82890030691187 |
| Llama 1B Instruct  | 512   | 22.919538703371582 |

Reviewed By: cccclai

Differential Revision: D76634688
@rohansjoshi @facebook-github-bot
Added evaluation script for qualcomm LlamaModel (pytorch#11663)
d4f2c9e 
Summary:
Pull Request resolved: pytorch#11663

Script for evaluating models which follow qualcomm's LlamaModel definition, on lm eval harness tasks such as WikiText

Results for WikiText evaluation task:

| Model Name | max_seq_len | word_perplexity
|----------|----------|----------|
| Llama 1B Instruct  | 128   | 34.82890030691187 |
| Llama 1B Instruct  | 512   | 22.919538703371582 |

Reviewed By: cccclai

Differential Revision: D76634688
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76634688

@facebook-github-bot facebook-github-bot merged commit 057558f into pytorch:main Jun 16, 2025
101 of 104 checks passed
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Jun 17, 2025
@rohansjoshi @abhinaykukkadapu
Added evaluation script for qualcomm LlamaModel
105da68 
Differential Revision: D76634688

Pull Request resolved: pytorch#11663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohansjoshi @facebook-github-bot @haowhsu-quic @cccclai