Define ET_HAS_EXCEPTIONS macro #11664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11664
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added
the
release notes: api
swolchok
reviewed
Jun 14, 2025
|
cannot find an actual error message in lintrunner output. checked out PR and |
swolchok
force-pushed
the
gh/swolchok/456/orig
branch
from
ba40863 to
8aa7e8b
Compare
swolchok
approved these changes
Jun 14, 2025
|
cannot repro lintrunner failure, merging to get the branch in sync |
|
oh, lintrunner is required |
Pull Request resolved: #11603 To support passing ET_USE_PYTORCH_HEADERS only when exceptions are enabled. ghstack-source-id: 290334875 @exported-using-ghexport Differential Revision: [D76470039](https://our.internmc.facebook.com/intern/diff/D76470039/)
swolchok
force-pushed
the
gh/swolchok/456/orig
branch
from
8aa7e8b to
9f82ef7
Compare
|
CI green except for lintrunner. rebasing to see if that failure (lintrunner init) goes away. |
lintrunner init is failing on main. landing based on previous green-except-lintrunner run. |
abhinaykukkadapu
pushed a commit
to abhinaykukkadapu/executorch
that referenced
this pull request
Jun 17, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#11603 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/456/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11603 by @swolchok
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/456/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/456/orig
@diff-train-skip-merge