ET_HAS_EXCEPTIONS: require defined(_MSC_VER) to conclude _HAS_EXCEPTIONS implies exceptions are on #11770
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ONS implies exceptions are on _HAS_EXCEPTIONS might get defined on some other platform by coincidence; require it to be actual MSVC for us to conclude exceptions are on. Differential Revision: [D76857541](https://our.internmc.facebook.com/intern/diff/D76857541/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11770
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3ad7ab3 with merge base 496cb05 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Jun 17, 2025
…ONS implies exceptions are on _HAS_EXCEPTIONS might get defined on some other platform by coincidence; require it to be actual MSVC for us to conclude exceptions are on. Differential Revision: [D76857541](https://our.internmc.facebook.com/intern/diff/D76857541/) ghstack-source-id: 291115126 Pull Request resolved: #11770
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76857541 |
…HAS_EXCEPTIONS implies exceptions are on" _HAS_EXCEPTIONS might get defined on some other platform by coincidence; require it to be actual MSVC for us to conclude exceptions are on. Differential Revision: [D76857541](https://our.internmc.facebook.com/intern/diff/D76857541/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 18, 2025
…ONS implies exceptions are on Pull Request resolved: #11770 _HAS_EXCEPTIONS might get defined on some other platform by coincidence; require it to be actual MSVC for us to conclude exceptions are on. Differential Revision: [D76857541](https://our.internmc.facebook.com/intern/diff/D76857541/) ghstack-source-id: 291364567
|
This pull request was exported from Phabricator. Differential Revision: D76857541 |
|
ping reviewers @JacobSzwejbka @lucylq |
…HAS_EXCEPTIONS implies exceptions are on" _HAS_EXCEPTIONS might get defined on some other platform by coincidence; require it to be actual MSVC for us to conclude exceptions are on. Differential Revision: [D76857541](https://our.internmc.facebook.com/intern/diff/D76857541/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 20, 2025
…ONS implies exceptions are on Pull Request resolved: #11770 _HAS_EXCEPTIONS might get defined on some other platform by coincidence; require it to be actual MSVC for us to conclude exceptions are on. ghstack-source-id: 291685590 Differential Revision: [D76857541](https://our.internmc.facebook.com/intern/diff/D76857541/)
|
This pull request was exported from Phabricator. Differential Revision: D76857541 |
manuelcandales
approved these changes
Jun 20, 2025
facebook-github-bot
merged commit d7b2731
into
gh/swolchok/461/base
96 of 98 checks passed
swolchok
added a commit
that referenced
this pull request
Jun 20, 2025
…ONS implies exceptions are on (#11831) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11770 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/461/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/461/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/461/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
_HAS_EXCEPTIONS might get defined on some other platform by coincidence; require it to be actual MSVC for us to conclude exceptions are on.
Differential Revision: D76857541