Skip to content

Reapply changes reverted by #11506 #12121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jun 30, 2025

Stack from ghstack (oldest at bottom):

This change seems to have accidentally reverted several of my changes due to (presumably) a bad rebase.

Differential Revision: D77559984

This change seems to have accidentally reverted several of my changes due to (presumably) a bad rebase.

Differential Revision: [D77559984](https://our.internmc.facebook.com/intern/diff/D77559984/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12121

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs

As of commit 6f14cdf with merge base bed504e (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 30, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77559984

@swolchok swolchok added the release notes: none Do not include this in the release notes label Jul 2, 2025
This change seems to have accidentally reverted several of my changes due to (presumably) a bad rebase.

Differential Revision: [D77559984](https://our.internmc.facebook.com/intern/diff/D77559984/)

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 2, 2025
Pull Request resolved: #12121

This change seems to have accidentally reverted several of my changes due to (presumably) a bad rebase.
ghstack-source-id: 293898720
@exported-using-ghexport

Differential Revision: [D77559984](https://our.internmc.facebook.com/intern/diff/D77559984/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77559984

@facebook-github-bot facebook-github-bot merged commit 78b54ca into gh/swolchok/487/base Jul 2, 2025
95 of 98 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/487/head branch July 2, 2025 22:04
swolchok added a commit that referenced this pull request Jul 2, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #12121 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/487/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/487/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/487/orig
@diff-train-skip-merge

Co-authored-by: Scott Wolchok <[email protected]>
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: pytorch#12121 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/487/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/487/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/487/orig
@diff-train-skip-merge

Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants